| Message ID | 20250429174125.2194499-1-wens@kernel.org |
|---|---|
| State | New |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [1/2] mmc: rockchip_dw_mmc: Enable by default for all supported SoCs | expand |
Please ignore this. I accidentally sent out the patches with incorrect patman tags. ChenYu On Wed, Apr 30, 2025 at 1:41 AM Chen-Yu Tsai <wens@kernel.org> wrote: > > From: Chen-Yu Tsai <wens@csie.org> > > The rockchip_dw_mmc driver supports the MMC controller found in Rockchip > SoCs. This controller is used for the SD card on all SoCs and eMMC on > older SoCs. Almost all defconfigs for Rockchip platforms have this > enabled. > > Enable it by default for all supported Rockchip SoCs. Disable it > explicitly in defconfigs that previously didn't have it enabled. Of > these, only the Cool Pi GenBook w/ CM5 doesn't actually use the > controller. The other two, the Geekbox and the RV1108 EVB, both have > MMC enabled in their device trees. With this patch, they will gain > support for MMC automatically. > > Also limit the driver to Rockchip platforms only, like what is done for > the other dw_mmc platform glue drivers. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > > Changes in v2: > - Made CONFIG_MMC_DW_ROCKCHIP depend on ARCH_ROCKCHIP > > configs/coolpi-cm5-genbook-rk3588_defconfig | 1 + > drivers/mmc/Kconfig | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/configs/coolpi-cm5-genbook-rk3588_defconfig b/configs/coolpi-cm5-genbook-rk3588_defconfig > index 3eb5dc968af6..92676ebb984a 100644 > --- a/configs/coolpi-cm5-genbook-rk3588_defconfig > +++ b/configs/coolpi-cm5-genbook-rk3588_defconfig > @@ -65,6 +65,7 @@ CONFIG_MMC_HS400_ES_SUPPORT=y > CONFIG_SPL_MMC_HS400_ES_SUPPORT=y > CONFIG_MMC_HS400_SUPPORT=y > CONFIG_SPL_MMC_HS400_SUPPORT=y > +# CONFIG_MMC_DW is not set > CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_SDMA=y > CONFIG_MMC_SDHCI_ROCKCHIP=y > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index 6740591a6533..ec9e9d51fbf9 100644 > --- a/drivers/mmc/Kconfig > +++ b/drivers/mmc/Kconfig > @@ -251,6 +251,7 @@ config MMC_DAVINCI > config MMC_DW > bool "Synopsys DesignWare Memory Card Interface" > select BOUNCE_BUFFER > + default y if ARCH_ROCKCHIP > help > This selects support for the Synopsys DesignWare Mobile Storage IP > block, this provides host support for SD and MMC interfaces, in both > @@ -286,6 +287,8 @@ config MMC_DW_ROCKCHIP > bool "Rockchip SD/MMC controller support" > depends on OF_CONTROL > depends on MMC_DW > + depends on ARCH_ROCKCHIP > + default y > help > This enables support for the Rockchip SD/MMM controller, which is > based on Designware IP. The device is compatible with at least > -- > 2.39.5 >
diff --git a/configs/coolpi-cm5-genbook-rk3588_defconfig b/configs/coolpi-cm5-genbook-rk3588_defconfig index 3eb5dc968af6..92676ebb984a 100644 --- a/configs/coolpi-cm5-genbook-rk3588_defconfig +++ b/configs/coolpi-cm5-genbook-rk3588_defconfig @@ -65,6 +65,7 @@ CONFIG_MMC_HS400_ES_SUPPORT=y CONFIG_SPL_MMC_HS400_ES_SUPPORT=y CONFIG_MMC_HS400_SUPPORT=y CONFIG_SPL_MMC_HS400_SUPPORT=y +# CONFIG_MMC_DW is not set CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_ROCKCHIP=y diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 6740591a6533..ec9e9d51fbf9 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -251,6 +251,7 @@ config MMC_DAVINCI config MMC_DW bool "Synopsys DesignWare Memory Card Interface" select BOUNCE_BUFFER + default y if ARCH_ROCKCHIP help This selects support for the Synopsys DesignWare Mobile Storage IP block, this provides host support for SD and MMC interfaces, in both @@ -286,6 +287,8 @@ config MMC_DW_ROCKCHIP bool "Rockchip SD/MMC controller support" depends on OF_CONTROL depends on MMC_DW + depends on ARCH_ROCKCHIP + default y help This enables support for the Rockchip SD/MMM controller, which is based on Designware IP. The device is compatible with at least