diff mbox series

[v2] board: starfive: Update the maintainer file for VisionFive 2 board

Message ID 20250205025652.5171-1-hal.feng@starfivetech.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series [v2] board: starfive: Update the maintainer file for VisionFive 2 board | expand

Commit Message

Hal Feng Feb. 5, 2025, 2:56 a.m. UTC 
Update the maintainer file and mark jh7110 related files with N: pattern.

Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---

Changes since v1:
- Mark jh7110 related files with N: pattern.

History:
v1: https://lore.kernel.org/all/20250127083814.67839-1-hal.feng@starfivetech.com/

---
 board/starfive/visionfive2/MAINTAINERS | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


base-commit: 97c125e6bb441a8062bdd28e82f17b1da1224416

Comments

Tom Rini Feb. 5, 2025, 1:58 p.m. UTC | #1 
On Wed, Feb 05, 2025 at 10:56:52AM +0800, Hal Feng wrote:

> Update the maintainer file and mark jh7110 related files with N: pattern.
> 
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> 
> Changes since v1:
> - Mark jh7110 related files with N: pattern.
> 
> History:
> v1: https://lore.kernel.org/all/20250127083814.67839-1-hal.feng@starfivetech.com/
> 
> ---
>  board/starfive/visionfive2/MAINTAINERS | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS
> index d7f638f9b41..87589553150 100644
> --- a/board/starfive/visionfive2/MAINTAINERS
> +++ b/board/starfive/visionfive2/MAINTAINERS
> @@ -1,8 +1,10 @@
>  STARFIVE JH7110 VISIONFIVE2 BOARD
>  M:	Minda Chen <minda.chen@starfivetech.com>
> +M:	Hal Feng <hal.feng@starfivetech.com>
>  S:	Maintained
> -F:	arch/riscv/include/asm/arch-jh7110/
>  F:	board/starfive/visionfive2/
> +F:	doc/board/starfive/visionfive2.rst
>  F:	include/configs/starfive-visionfive2.h
>  F:	configs/starfive_visionfive2_defconfig
> -F:	drivers/pci/pcie_starfive_jh7110.c
> +F:	drivers/ram/starfive/
> +N:	jh7110

Might as well use N for visionfive2 as well (and maybe add an entry for
general starfive files and N that too). Thanks!
Hal Feng Feb. 6, 2025, 6:54 a.m. UTC | #2 
> On 05.02.25 21:58, Tom Rini wrote:
> On Wed, Feb 05, 2025 at 10:56:52AM +0800, Hal Feng wrote:
> 
> > Update the maintainer file and mark jh7110 related files with N: pattern.
> >
> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> >
> > Changes since v1:
> > - Mark jh7110 related files with N: pattern.
> >
> > History:
> > v1:
> > https://lore.kernel.org/all/20250127083814.67839-1-hal.feng@starfivete
> > ch.com/
> >
> > ---
> >  board/starfive/visionfive2/MAINTAINERS | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/starfive/visionfive2/MAINTAINERS
> > b/board/starfive/visionfive2/MAINTAINERS
> > index d7f638f9b41..87589553150 100644
> > --- a/board/starfive/visionfive2/MAINTAINERS
> > +++ b/board/starfive/visionfive2/MAINTAINERS
> > @@ -1,8 +1,10 @@
> >  STARFIVE JH7110 VISIONFIVE2 BOARD
> >  M:	Minda Chen <minda.chen@starfivetech.com>
> > +M:	Hal Feng <hal.feng@starfivetech.com>
> >  S:	Maintained
> > -F:	arch/riscv/include/asm/arch-jh7110/
> >  F:	board/starfive/visionfive2/
> > +F:	doc/board/starfive/visionfive2.rst
> >  F:	include/configs/starfive-visionfive2.h
> >  F:	configs/starfive_visionfive2_defconfig
> > -F:	drivers/pci/pcie_starfive_jh7110.c
> > +F:	drivers/ram/starfive/
> > +N:	jh7110
> 
> Might as well use N for visionfive2 as well (and maybe add an entry for
> general starfive files and N that too). Thanks!

OK, will use N: for visionfive2. But I think it's not appropriate to use N:
for starfive, because the other SOCs or boards of StarFive will be
maintained by other appointed people.

Best regards,
Hal
Simon Glass Feb. 6, 2025, 12:23 p.m. UTC | #3 
Hi,

On Wed, 5 Feb 2025 at 06:58, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Feb 05, 2025 at 10:56:52AM +0800, Hal Feng wrote:
>
> > Update the maintainer file and mark jh7110 related files with N: pattern.
> >
> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> >
> > Changes since v1:
> > - Mark jh7110 related files with N: pattern.
> >
> > History:
> > v1: https://lore.kernel.org/all/20250127083814.67839-1-hal.feng@starfivetech.com/
> >
> > ---
> >  board/starfive/visionfive2/MAINTAINERS | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS
> > index d7f638f9b41..87589553150 100644
> > --- a/board/starfive/visionfive2/MAINTAINERS
> > +++ b/board/starfive/visionfive2/MAINTAINERS
> > @@ -1,8 +1,10 @@
> >  STARFIVE JH7110 VISIONFIVE2 BOARD
> >  M:   Minda Chen <minda.chen@starfivetech.com>
> > +M:   Hal Feng <hal.feng@starfivetech.com>
> >  S:   Maintained
> > -F:   arch/riscv/include/asm/arch-jh7110/
> >  F:   board/starfive/visionfive2/
> > +F:   doc/board/starfive/visionfive2.rst
> >  F:   include/configs/starfive-visionfive2.h
> >  F:   configs/starfive_visionfive2_defconfig
> > -F:   drivers/pci/pcie_starfive_jh7110.c
> > +F:   drivers/ram/starfive/
> > +N:   jh7110
>
> Might as well use N for visionfive2 as well (and maybe add an entry for
> general starfive files and N that too). Thanks!

As a new maintainer, would it be possible to take a look at the
failing test? [1]

Regards,
Simon

[1] https://ci.u-boot.org/u-boot/u-boot/-/jobs/25452
Hal Feng Feb. 7, 2025, 1:55 a.m. UTC | #4 
> On 06.02.25 20:23, Simon Glass wrote:
> Hi,
> 
> On Wed, 5 Feb 2025 at 06:58, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Feb 05, 2025 at 10:56:52AM +0800, Hal Feng wrote:
> >
> > > Update the maintainer file and mark jh7110 related files with N: pattern.
> > >
> > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > > ---
> > >
> > > Changes since v1:
> > > - Mark jh7110 related files with N: pattern.
> > >
> > > History:
> > > v1:
> > > https://lore.kernel.org/all/20250127083814.67839-1-hal.feng@starfive
> > > tech.com/
> > >
> > > ---
> > >  board/starfive/visionfive2/MAINTAINERS | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/board/starfive/visionfive2/MAINTAINERS
> > > b/board/starfive/visionfive2/MAINTAINERS
> > > index d7f638f9b41..87589553150 100644
> > > --- a/board/starfive/visionfive2/MAINTAINERS
> > > +++ b/board/starfive/visionfive2/MAINTAINERS
> > > @@ -1,8 +1,10 @@
> > >  STARFIVE JH7110 VISIONFIVE2 BOARD
> > >  M:   Minda Chen <minda.chen@starfivetech.com>
> > > +M:   Hal Feng <hal.feng@starfivetech.com>
> > >  S:   Maintained
> > > -F:   arch/riscv/include/asm/arch-jh7110/
> > >  F:   board/starfive/visionfive2/
> > > +F:   doc/board/starfive/visionfive2.rst
> > >  F:   include/configs/starfive-visionfive2.h
> > >  F:   configs/starfive_visionfive2_defconfig
> > > -F:   drivers/pci/pcie_starfive_jh7110.c
> > > +F:   drivers/ram/starfive/
> > > +N:   jh7110
> >
> > Might as well use N for visionfive2 as well (and maybe add an entry
> > for general starfive files and N that too). Thanks!
> 
> As a new maintainer, would it be possible to take a look at the failing test? [1]
> 
> Regards,
> Simon
> 
> [1] https://ci.u-boot.org/u-boot/u-boot/-/jobs/25452

Has it been already fixed with the patch I sent before?

https://lore.kernel.org/all/20250116034534.91513-1-hal.feng@starfivetech.com/

Best regards,
Hal
diff mbox series

Patch

diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS
index d7f638f9b41..87589553150 100644
--- a/board/starfive/visionfive2/MAINTAINERS
+++ b/board/starfive/visionfive2/MAINTAINERS
@@ -1,8 +1,10 @@ 
 STARFIVE JH7110 VISIONFIVE2 BOARD
 M:	Minda Chen <minda.chen@starfivetech.com>
+M:	Hal Feng <hal.feng@starfivetech.com>
 S:	Maintained
-F:	arch/riscv/include/asm/arch-jh7110/
 F:	board/starfive/visionfive2/
+F:	doc/board/starfive/visionfive2.rst
 F:	include/configs/starfive-visionfive2.h
 F:	configs/starfive_visionfive2_defconfig
-F:	drivers/pci/pcie_starfive_jh7110.c
+F:	drivers/ram/starfive/
+N:	jh7110