diff mbox series

mmc: Kconfig: Correct dependencies SDHCI ADMA options

Message ID 20250115020737.230558-1-trini@konsulko.com
State New
Delegated to: Jaehoon Chung
Headers show
Series mmc: Kconfig: Correct dependencies SDHCI ADMA options | expand

Commit Message

Tom Rini Jan. 15, 2025, 2:07 a.m. UTC
The option MMC_SDHCI_ADMA_FORCE_32BIT is only tested or used when
MMC_SDHCI_ADMA or SPL_MMC_SDHCI_ADMA is enabled. And for
MMC_SDHCI_ADMA_64BIT the same is true except we also require
MMC_SDHCI_ADMA_FORCE_32BIT to be disabled.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peng Fan Jan. 15, 2025, 2:11 a.m. UTC | #1
> Subject: [PATCH] mmc: Kconfig: Correct dependencies SDHCI ADMA
> options
> 
> The option MMC_SDHCI_ADMA_FORCE_32BIT is only tested or used
> when MMC_SDHCI_ADMA or SPL_MMC_SDHCI_ADMA is enabled. And
> for MMC_SDHCI_ADMA_64BIT the same is true except we also require
> MMC_SDHCI_ADMA_FORCE_32BIT to be disabled.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>

Acked-by: Peng Fan <peng.fan@nxp.com>
Jaehoon Chung Jan. 15, 2025, 2:21 a.m. UTC | #2
> -----Original Message-----
> From: Tom Rini <trini@konsulko.com>
> Sent: Wednesday, January 15, 2025 11:08 AM
>
> The option MMC_SDHCI_ADMA_FORCE_32BIT is only tested or used when
> MMC_SDHCI_ADMA or SPL_MMC_SDHCI_ADMA is enabled. And for
> MMC_SDHCI_ADMA_64BIT the same is true except we also require
> MMC_SDHCI_ADMA_FORCE_32BIT to be disabled.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/mmc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index f4fdf15242ce..6dc8d3bf9fe2 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -527,6 +527,7 @@ config SPL_MMC_SDHCI_ADMA
>
>  config MMC_SDHCI_ADMA_FORCE_32BIT
>  	bool "Force 32 bit mode for ADMA on 64 bit platforms"
> +	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
>  	help
>  	  This forces SDHCI ADMA to be built for 32 bit descriptors, even
>  	  on a 64 bit platform where they would otherwise be assumed to
> @@ -536,6 +537,7 @@ config MMC_SDHCI_ADMA_FORCE_32BIT
>
>  config MMC_SDHCI_ADMA_64BIT
>  	bool "Use SHDCI ADMA with 64 bit descriptors"
> +	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
>  	depends on !MMC_SDHCI_ADMA_FORCE_32BIT
>  	default y if DMA_ADDR_T_64BIT
>  	help
> --
> 2.43.0
diff mbox series

Patch

diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index f4fdf15242ce..6dc8d3bf9fe2 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -527,6 +527,7 @@  config SPL_MMC_SDHCI_ADMA
 
 config MMC_SDHCI_ADMA_FORCE_32BIT
 	bool "Force 32 bit mode for ADMA on 64 bit platforms"
+	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
 	help
 	  This forces SDHCI ADMA to be built for 32 bit descriptors, even
 	  on a 64 bit platform where they would otherwise be assumed to
@@ -536,6 +537,7 @@  config MMC_SDHCI_ADMA_FORCE_32BIT
 
 config MMC_SDHCI_ADMA_64BIT
 	bool "Use SHDCI ADMA with 64 bit descriptors"
+	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
 	depends on !MMC_SDHCI_ADMA_FORCE_32BIT
 	default y if DMA_ADDR_T_64BIT
 	help