Message ID | 20241220222612.1757884-6-trini@konsulko.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | Rework the BLK symbol usage in Kconfig | expand |
On Fri, 20 Dec 2024 at 22:36, Tom Rini <trini@konsulko.com> wrote: > In the case of MTD_BLOCK and UBI_BLOCK they should be select'ing BLK as > they provide block device functionality and not depending on some other > block device already being enabled too (as is the typical case). > > Signed-off-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Peter Robinson <pbrobinson@gmail.com> > --- > Cc: Heiko Schocher <hs@denx.de> > Cc: Kyungmin Park <kmpark@infradead.org> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > --- > drivers/mtd/Kconfig | 2 +- > drivers/mtd/ubi/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > index 678bbde89e68..df178665f9bc 100644 > --- a/drivers/mtd/Kconfig > +++ b/drivers/mtd/Kconfig > @@ -34,7 +34,7 @@ config MTD_CONCAT > > config MTD_BLOCK > bool "Enable block device access to MTD devices" > - depends on BLK > + select BLK > help > Enable support for block device access to MTD devices > using blk_ops abstraction. > diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig > index c027d898a640..ba77c0347365 100644 > --- a/drivers/mtd/ubi/Kconfig > +++ b/drivers/mtd/ubi/Kconfig > @@ -116,7 +116,7 @@ config MTD_UBI_FM_DEBUG > > config UBI_BLOCK > bool "Enable UBI block device support" > - depends on BLK > + select BLK > help > Enable UBI block device support using blk_ops abstraction. > > -- > 2.43.0 > >
Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: > In the case of MTD_BLOCK and UBI_BLOCK they should be select'ing BLK as > they provide block device functionality and not depending on some other > block device already being enabled too (as is the typical case). > > Signed-off-by: Tom Rini <trini@konsulko.com> Makes sense to me, Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 678bbde89e68..df178665f9bc 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -34,7 +34,7 @@ config MTD_CONCAT config MTD_BLOCK bool "Enable block device access to MTD devices" - depends on BLK + select BLK help Enable support for block device access to MTD devices using blk_ops abstraction. diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig index c027d898a640..ba77c0347365 100644 --- a/drivers/mtd/ubi/Kconfig +++ b/drivers/mtd/ubi/Kconfig @@ -116,7 +116,7 @@ config MTD_UBI_FM_DEBUG config UBI_BLOCK bool "Enable UBI block device support" - depends on BLK + select BLK help Enable UBI block device support using blk_ops abstraction.
In the case of MTD_BLOCK and UBI_BLOCK they should be select'ing BLK as they provide block device functionality and not depending on some other block device already being enabled too (as is the typical case). Signed-off-by: Tom Rini <trini@konsulko.com> --- Cc: Heiko Schocher <hs@denx.de> Cc: Kyungmin Park <kmpark@infradead.org> Cc: Michael Trimarchi <michael@amarulasolutions.com> --- drivers/mtd/Kconfig | 2 +- drivers/mtd/ubi/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)