Message ID | 20241220222612.1757884-2-trini@konsulko.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | Rework the BLK symbol usage in Kconfig | expand |
> -----Original Message----- > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Tom Rini > Sent: Saturday, December 21, 2024 7:22 AM > > At this point in time, MMC will always have BLK enabled, so we do not > need to list that as a dependency for MMC drivers. > > Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/Kconfig | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index f4fdf15242ce..9f2fecce3826 100644 > --- a/drivers/mmc/Kconfig > +++ b/drivers/mmc/Kconfig > @@ -338,7 +338,7 @@ config MMC_MXC > > config MMC_OWL > bool "Actions OWL Multimedia Card Interface support" > - depends on ARCH_OWL && DM_MMC && BLK > + depends on ARCH_OWL && DM_MMC > help > This selects the OWL SD/MMC host controller found on board > based on Actions S700/S900 SoC. > @@ -633,7 +633,7 @@ config MMC_SDHCI_AM654 > bool "SDHCI Controller on TI's Am654 devices" > depends on ARCH_K3 > depends on MMC_SDHCI > - depends on DM_MMC && OF_CONTROL && BLK > + depends on DM_MMC && OF_CONTROL > depends on REGMAP > select MMC_SDHCI_IO_ACCESSORS > help > @@ -716,7 +716,7 @@ config MMC_SDHCI_PIC32 > config MMC_SDHCI_ROCKCHIP > bool "Arasan SDHCI controller for Rockchip support" > depends on ARCH_ROCKCHIP > - depends on DM_MMC && BLK > + depends on DM_MMC > depends on MMC_SDHCI > help > Support for Arasan SDHCI host controller on Rockchip ARM SoCs platform > @@ -764,7 +764,7 @@ config MMC_SDHCI_XENON > > config MMC_SDHCI_TANGIER > bool "Tangier SDHCI controller support" > - depends on DM_MMC && BLK > + depends on DM_MMC > depends on MMC_SDHCI > help > This selects support for SDHCI controller on Tanginer > @@ -800,7 +800,7 @@ config TEGRA124_MMC_DISABLE_EXT_LOOPBACK > > config MMC_SDHCI_ZYNQ > bool "Arasan SDHCI controller support" > - depends on DM_MMC && OF_CONTROL && BLK > + depends on DM_MMC && OF_CONTROL > depends on MMC_SDHCI > help > Support for Arasan SDHCI host controller on Zynq/ZynqMP ARM SoCs platform > @@ -842,7 +842,7 @@ config MMC_SUNXI_HAS_MODE_SWITCH > > config MMC_PITON > bool "MMC support for OpenPiton SoC" > - depends on DM_MMC && BLK > + depends on DM_MMC > help > This selects support for the SD host controller on OpenPiton SoC. > Note that this SD controller directly exposes the contents of the > -- > 2.43.0
Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: > At this point in time, MMC will always have BLK enabled, so we do not This was not clear to me as to why until I read the definition of the BLK symbol. Could you please reword the commit log to make this clearer? Something like: At this point in time, BLK defaults to enabled when MMC is enabled, so we do not With that, Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On Tue, Jan 14, 2025 at 02:25:45PM +0100, Quentin Schulz wrote: > Hi Tom, > > On 12/20/24 11:22 PM, Tom Rini wrote: > > At this point in time, MMC will always have BLK enabled, so we do not > > This was not clear to me as to why until I read the definition of the BLK > symbol. Could you please reword the commit log to make this clearer? > Something like: > > At this point in time, BLK defaults to enabled when MMC is enabled, so we do > not > > With that, > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Will do, thanks.
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index f4fdf15242ce..9f2fecce3826 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -338,7 +338,7 @@ config MMC_MXC config MMC_OWL bool "Actions OWL Multimedia Card Interface support" - depends on ARCH_OWL && DM_MMC && BLK + depends on ARCH_OWL && DM_MMC help This selects the OWL SD/MMC host controller found on board based on Actions S700/S900 SoC. @@ -633,7 +633,7 @@ config MMC_SDHCI_AM654 bool "SDHCI Controller on TI's Am654 devices" depends on ARCH_K3 depends on MMC_SDHCI - depends on DM_MMC && OF_CONTROL && BLK + depends on DM_MMC && OF_CONTROL depends on REGMAP select MMC_SDHCI_IO_ACCESSORS help @@ -716,7 +716,7 @@ config MMC_SDHCI_PIC32 config MMC_SDHCI_ROCKCHIP bool "Arasan SDHCI controller for Rockchip support" depends on ARCH_ROCKCHIP - depends on DM_MMC && BLK + depends on DM_MMC depends on MMC_SDHCI help Support for Arasan SDHCI host controller on Rockchip ARM SoCs platform @@ -764,7 +764,7 @@ config MMC_SDHCI_XENON config MMC_SDHCI_TANGIER bool "Tangier SDHCI controller support" - depends on DM_MMC && BLK + depends on DM_MMC depends on MMC_SDHCI help This selects support for SDHCI controller on Tanginer @@ -800,7 +800,7 @@ config TEGRA124_MMC_DISABLE_EXT_LOOPBACK config MMC_SDHCI_ZYNQ bool "Arasan SDHCI controller support" - depends on DM_MMC && OF_CONTROL && BLK + depends on DM_MMC && OF_CONTROL depends on MMC_SDHCI help Support for Arasan SDHCI host controller on Zynq/ZynqMP ARM SoCs platform @@ -842,7 +842,7 @@ config MMC_SUNXI_HAS_MODE_SWITCH config MMC_PITON bool "MMC support for OpenPiton SoC" - depends on DM_MMC && BLK + depends on DM_MMC help This selects support for the SD host controller on OpenPiton SoC. Note that this SD controller directly exposes the contents of the
At this point in time, MMC will always have BLK enabled, so we do not need to list that as a dependency for MMC drivers. Signed-off-by: Tom Rini <trini@konsulko.com> --- drivers/mmc/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)