| Message ID | 20241115165400.2486914-3-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | ce8b8ce8dc302b7e683223719811713c4e025dd0 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/3] aspeed: Fix Kconfig logic on "DM_REGULATOR" and ASPEED_AST2500 | expand |
On Fri, 15 Nov 2024 at 09:54, Tom Rini <trini@konsulko.com> wrote: > > Given that ARCH_SUNXI already implies that USB_GADGET should be enable, > we should also imply USB being enabled. > > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Is this a tiny bit of a cheat to avoid patch 1/8 of Simon's bootstd > series? Yes, a little. But it's also correct I believe. > > Cc: Andre Przywara <andre.przywara@arm.com> > Cc: Simon Glass <sjg@chromium.org> > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> (from my side)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 7282c4123b08..3ebda07b00c1 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1177,7 +1177,6 @@ config ARCH_SUNXI select SUNXI_GPIO select SYS_NS16550 select SYS_THUMB_BUILD if !ARM64 - select USB if DISTRO_DEFAULTS select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST select USB_STORAGE if DISTRO_DEFAULTS && USB_HOST select SPL_USE_TINY_PRINTF if SPL @@ -1203,6 +1202,7 @@ config ARCH_SUNXI imply SYSRESET imply SYSRESET_WATCHDOG imply SYSRESET_WATCHDOG_AUTO + imply USB imply USB_GADGET imply WDT
Given that ARCH_SUNXI already implies that USB_GADGET should be enable, we should also imply USB being enabled. Signed-off-by: Tom Rini <trini@konsulko.com> --- Is this a tiny bit of a cheat to avoid patch 1/8 of Simon's bootstd series? Yes, a little. But it's also correct I believe. Cc: Andre Przywara <andre.przywara@arm.com> Cc: Simon Glass <sjg@chromium.org> --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)