| Message ID | 20241115165400.2486914-1-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | 26a2b69b2440d261a3fd814d37d023e704e92853 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/3] aspeed: Fix Kconfig logic on "DM_REGULATOR" and ASPEED_AST2500 | expand |
On Fri, Nov 15, 2024 at 1:54 PM Tom Rini <trini@konsulko.com> wrote: > > It is not the case that we can only pick ASPEED_AST2500 if DM_REGULATOR > is enabled, but rather choosing ASPEED_AST2500 means we must select > DM_REGULATOR. Do you mean DM_RESET instead?
On Fri, Nov 15, 2024 at 02:41:05PM -0300, Fabio Estevam wrote: > On Fri, Nov 15, 2024 at 1:54 PM Tom Rini <trini@konsulko.com> wrote: > > > > It is not the case that we can only pick ASPEED_AST2500 if DM_REGULATOR > > is enabled, but rather choosing ASPEED_AST2500 means we must select > > DM_REGULATOR. > > Do you mean DM_RESET instead? Yes, yes I did, thanks. I'll fixup when applying if there's no need for a v2.
On Fri, 15 Nov 2024 10:53:57 -0600, Tom Rini wrote: > It is not the case that we can only pick ASPEED_AST2500 if DM_REGULATOR > is enabled, but rather choosing ASPEED_AST2500 means we must select > DM_REGULATOR. > > Applied to u-boot/next, thanks!
diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig index 1e7dc10e170f..9cf60378c118 100644 --- a/arch/arm/mach-aspeed/Kconfig +++ b/arch/arm/mach-aspeed/Kconfig @@ -16,8 +16,8 @@ choice config ASPEED_AST2500 bool "Support Aspeed AST2500 SoC" - depends on DM_RESET select CPU_ARM1176 + select DM_RESET help The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU. It is used as Board Management Controller on many server boards,
It is not the case that we can only pick ASPEED_AST2500 if DM_REGULATOR is enabled, but rather choosing ASPEED_AST2500 means we must select DM_REGULATOR. Signed-off-by: Tom Rini <trini@konsulko.com> --- Cc: Maxim Sloyko <maxims@google.com> --- arch/arm/mach-aspeed/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)