| Message ID | 20241102150413.133499-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | Accepted |
| Commit | b891826067c2d51cdb0f46b3763642bf8484ebb8 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/1] upl: fix parsing of DT property | expand |
On Sat, 02 Nov 2024 16:04:13 +0100, Heinrich Schuchardt wrote: > When calling decode_addr_size() we must pass the size of the device-tree > property and not sizeof(void *). > > Applied to u-boot/master, thanks!
diff --git a/boot/upl_read.c b/boot/upl_read.c index 5063897a132..be3e1d116e1 100644 --- a/boot/upl_read.c +++ b/boot/upl_read.c @@ -520,7 +520,7 @@ static int decode_upl_graphics(struct upl *upl, ofnode node) return log_msg_ret("reg", -EINVAL); } - len = decode_addr_size(upl, buf, sizeof(buf), &gra->reg); + len = decode_addr_size(upl, buf, size, &gra->reg); if (len < 0) return log_msg_ret("buf", len);
When calling decode_addr_size() we must pass the size of the device-tree property and not sizeof(void *). Fixes: 90469da3da0d ("upl: Add support for reading a upl handoff") Addresses-Coverity-ID: 510459 Wrong sizeof argument Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- boot/upl_read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)