Message ID | 20240815202424.766778-9-sjg@chromium.org |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | efi: Add a test for EFI bootmeth | expand |
Hi Simon, On Thu, 15 Aug 2024 at 23:24, Simon Glass <sjg@chromium.org> wrote: > > Sandbox is not a real architecture, but within U-Boot it is real enough. > We should not need to pretend it is x86 or ARM anywhere in the code. > > Also we want to be able to locate the sandbox app using a single > filename, 'bootsbox.efi', to avoid needing tests to produce different > files on each host architecture. > > Drop the confusing use of host architecture and just let sandbox be > sandbox. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: 3a0654ecd0d ("efi_loader: correctly identify binary name") The reasoning here, was that sandbox is compiled for the host arch, that's why the name were preserved. I don't mind changing that, but we don't need the fixes tag. Without that Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > > (no changes since v3) > > Changes in v3: > - Put back the Linaro copyright accidentally removed > > include/efi_default_filename.h | 24 ++---------------------- > 1 file changed, 2 insertions(+), 22 deletions(-) > > diff --git a/include/efi_default_filename.h b/include/efi_default_filename.h > index 77932984b55..06ca8735002 100644 > --- a/include/efi_default_filename.h > +++ b/include/efi_default_filename.h > @@ -16,26 +16,8 @@ > #undef BOOTEFI_NAME > > #ifdef CONFIG_SANDBOX > - > -#if HOST_ARCH == HOST_ARCH_X86_64 > -#define BOOTEFI_NAME "BOOTX64.EFI" > -#elif HOST_ARCH == HOST_ARCH_X86 > -#define BOOTEFI_NAME "BOOTIA32.EFI" > -#elif HOST_ARCH == HOST_ARCH_AARCH64 > -#define BOOTEFI_NAME "BOOTAA64.EFI" > -#elif HOST_ARCH == HOST_ARCH_ARM > -#define BOOTEFI_NAME "BOOTARM.EFI" > -#elif HOST_ARCH == HOST_ARCH_RISCV32 > -#define BOOTEFI_NAME "BOOTRISCV32.EFI" > -#elif HOST_ARCH == HOST_ARCH_RISCV64 > -#define BOOTEFI_NAME "BOOTRISCV64.EFI" > -#else > -#error Unsupported UEFI architecture > -#endif > - > -#else > - > -#if defined(CONFIG_ARM64) > +#define BOOTEFI_NAME "BOOTSBOX.EFI" > +#elif defined(CONFIG_ARM64) > #define BOOTEFI_NAME "BOOTAA64.EFI" > #elif defined(CONFIG_ARM) > #define BOOTEFI_NAME "BOOTARM.EFI" > @@ -52,5 +34,3 @@ > #endif > > #endif > - > -#endif > -- > 2.34.1 >
diff --git a/include/efi_default_filename.h b/include/efi_default_filename.h index 77932984b55..06ca8735002 100644 --- a/include/efi_default_filename.h +++ b/include/efi_default_filename.h @@ -16,26 +16,8 @@ #undef BOOTEFI_NAME #ifdef CONFIG_SANDBOX - -#if HOST_ARCH == HOST_ARCH_X86_64 -#define BOOTEFI_NAME "BOOTX64.EFI" -#elif HOST_ARCH == HOST_ARCH_X86 -#define BOOTEFI_NAME "BOOTIA32.EFI" -#elif HOST_ARCH == HOST_ARCH_AARCH64 -#define BOOTEFI_NAME "BOOTAA64.EFI" -#elif HOST_ARCH == HOST_ARCH_ARM -#define BOOTEFI_NAME "BOOTARM.EFI" -#elif HOST_ARCH == HOST_ARCH_RISCV32 -#define BOOTEFI_NAME "BOOTRISCV32.EFI" -#elif HOST_ARCH == HOST_ARCH_RISCV64 -#define BOOTEFI_NAME "BOOTRISCV64.EFI" -#else -#error Unsupported UEFI architecture -#endif - -#else - -#if defined(CONFIG_ARM64) +#define BOOTEFI_NAME "BOOTSBOX.EFI" +#elif defined(CONFIG_ARM64) #define BOOTEFI_NAME "BOOTAA64.EFI" #elif defined(CONFIG_ARM) #define BOOTEFI_NAME "BOOTARM.EFI" @@ -52,5 +34,3 @@ #endif #endif - -#endif
Sandbox is not a real architecture, but within U-Boot it is real enough. We should not need to pretend it is x86 or ARM anywhere in the code. Also we want to be able to locate the sandbox app using a single filename, 'bootsbox.efi', to avoid needing tests to produce different files on each host architecture. Drop the confusing use of host architecture and just let sandbox be sandbox. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: 3a0654ecd0d ("efi_loader: correctly identify binary name") --- (no changes since v3) Changes in v3: - Put back the Linaro copyright accidentally removed include/efi_default_filename.h | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-)