| Message ID | 20240724150922.2343249-13-sjg@chromium.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | global_data: Reduce size of struct global_data | expand |
Hi Simon, On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > We don't need a full word for this boolean value. Convert it into a flag > to save space in global_data. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- > arch/arm/mach-exynos/spl_boot.c | 2 +- > arch/arm/mach-k3/common.c | 2 +- > arch/arm/mach-k3/r5/sysfw-loader.c | 2 +- > board/siemens/common/board_am335x.c | 2 +- > common/board_f.c | 2 +- > common/console.c | 14 +++++++------- > common/spl/spl.c | 2 +- > include/asm-generic/global_data.h | 17 +++++++---------- > 9 files changed, 21 insertions(+), 24 deletions(-) > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > index 76a69d7f958..dd748328293 100644 > --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c [...] > @@ -219,7 +210,7 @@ struct global_data { > #endif > #ifdef CONFIG_TIMER > /** > - * @timer: timer instance for Driver Model > +s * @timer: timer instance for Driver Model an unintentional change? > */ > struct udevice *timer; > #endif the rest looks good to me and you can add my Reviewed-by: if you remove the above chunk.
Hi Alexander, On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander <alexander.sverdlin@siemens.com> wrote: > > Hi Simon, > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > We don't need a full word for this boolean value. Convert it into a flag > > to save space in global_data. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- > > arch/arm/mach-exynos/spl_boot.c | 2 +- > > arch/arm/mach-k3/common.c | 2 +- > > arch/arm/mach-k3/r5/sysfw-loader.c | 2 +- > > board/siemens/common/board_am335x.c | 2 +- > > common/board_f.c | 2 +- > > common/console.c | 14 +++++++------- > > common/spl/spl.c | 2 +- > > include/asm-generic/global_data.h | 17 +++++++---------- > > 9 files changed, 21 insertions(+), 24 deletions(-) > > > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > index 76a69d7f958..dd748328293 100644 > > --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > [...] > > > @@ -219,7 +210,7 @@ struct global_data { > > #endif > > #ifdef CONFIG_TIMER > > /** > > - * @timer: timer instance for Driver Model > > +s * @timer: timer instance for Driver Model > > an unintentional change? > > > */ > > struct udevice *timer; > > #endif > > the rest looks good to me and you can add my > Reviewed-by: if you remove the above chunk. > Thank you. I'm not sure where that came from, but it seems to be gone now. Regards, Simon
On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote: > Hi Alexander, > > On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander > <alexander.sverdlin@siemens.com> wrote: > > > > Hi Simon, > > > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > > We don't need a full word for this boolean value. Convert it into a flag > > > to save space in global_data. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- > > > arch/arm/mach-exynos/spl_boot.c | 2 +- > > > arch/arm/mach-k3/common.c | 2 +- > > > arch/arm/mach-k3/r5/sysfw-loader.c | 2 +- > > > board/siemens/common/board_am335x.c | 2 +- > > > common/board_f.c | 2 +- > > > common/console.c | 14 +++++++------- > > > common/spl/spl.c | 2 +- > > > include/asm-generic/global_data.h | 17 +++++++---------- > > > 9 files changed, 21 insertions(+), 24 deletions(-) > > > > > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > index 76a69d7f958..dd748328293 100644 > > > --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > > [...] > > > > > @@ -219,7 +210,7 @@ struct global_data { > > > #endif > > > #ifdef CONFIG_TIMER > > > /** > > > - * @timer: timer instance for Driver Model > > > +s * @timer: timer instance for Driver Model > > > > an unintentional change? > > > > > */ > > > struct udevice *timer; > > > #endif > > > > the rest looks good to me and you can add my > > Reviewed-by: if you remove the above chunk. > > > > Thank you. I'm not sure where that came from, but it seems to be gone now. I fixed this up manually when applying (and added the tag).
On Thu, 29 Aug 2024 at 08:28, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote: > > Hi Alexander, > > > > On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander > > <alexander.sverdlin@siemens.com> wrote: > > > > > > Hi Simon, > > > > > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > > > We don't need a full word for this boolean value. Convert it into a flag > > > > to save space in global_data. > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > --- > > > > > > > > arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- > > > > arch/arm/mach-exynos/spl_boot.c | 2 +- > > > > arch/arm/mach-k3/common.c | 2 +- > > > > arch/arm/mach-k3/r5/sysfw-loader.c | 2 +- > > > > board/siemens/common/board_am335x.c | 2 +- > > > > common/board_f.c | 2 +- > > > > common/console.c | 14 +++++++------- > > > > common/spl/spl.c | 2 +- > > > > include/asm-generic/global_data.h | 17 +++++++---------- > > > > 9 files changed, 21 insertions(+), 24 deletions(-) > > > > > > > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > > index 76a69d7f958..dd748328293 100644 > > > > --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c > > > > > > [...] > > > > > > > @@ -219,7 +210,7 @@ struct global_data { > > > > #endif > > > > #ifdef CONFIG_TIMER > > > > /** > > > > - * @timer: timer instance for Driver Model > > > > +s * @timer: timer instance for Driver Model > > > > > > an unintentional change? > > > > > > > */ > > > > struct udevice *timer; > > > > #endif > > > > > > the rest looks good to me and you can add my > > > Reviewed-by: if you remove the above chunk. > > > > > > > Thank you. I'm not sure where that came from, but it seems to be gone now. > > I fixed this up manually when applying (and added the tag). Thanks! - Simon
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c index 76a69d7f958..dd748328293 100644 --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c @@ -117,7 +117,7 @@ static void mxs_spl_console_init(void) gd->bd = &bdata; gd->baudrate = CONFIG_BAUDRATE; serial_init(); - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; #endif } diff --git a/arch/arm/mach-exynos/spl_boot.c b/arch/arm/mach-exynos/spl_boot.c index bd5a06447b9..219d7fbf957 100644 --- a/arch/arm/mach-exynos/spl_boot.c +++ b/arch/arm/mach-exynos/spl_boot.c @@ -312,7 +312,7 @@ static void setup_global_data(gd_t *gdp) memzero((void *)gd, sizeof(gd_t)); gd->flags |= GD_FLG_RELOC; gd->baudrate = CONFIG_BAUDRATE; - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; } void board_init_f(unsigned long bootflag) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c index eaa7d361767..df48ec8d479 100644 --- a/arch/arm/mach-k3/common.c +++ b/arch/arm/mach-k3/common.c @@ -104,7 +104,7 @@ int early_console_init(void) gd->cur_serial_dev = dev; gd->flags |= GD_FLG_SERIAL_READY; - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; return 0; } diff --git a/arch/arm/mach-k3/r5/sysfw-loader.c b/arch/arm/mach-k3/r5/sysfw-loader.c index 94d051ba0fb..188731e673d 100644 --- a/arch/arm/mach-k3/r5/sysfw-loader.c +++ b/arch/arm/mach-k3/r5/sysfw-loader.c @@ -451,7 +451,7 @@ void k3_sysfw_loader(bool rom_loaded_sysfw, * the case when continuing to boot serially from the same * UART that the ROM loaded the initial bootloader from. */ - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) early_console_init(); #endif ret = spl_ymodem_load_image(&spl_image, &bootdev); diff --git a/board/siemens/common/board_am335x.c b/board/siemens/common/board_am335x.c index 2a727606bc3..e6537b0675a 100644 --- a/board/siemens/common/board_am335x.c +++ b/board/siemens/common/board_am335x.c @@ -36,7 +36,7 @@ void set_mux_conf_regs(void) /* enable early the console */ gd->baudrate = CONFIG_BAUDRATE; serial_init(); - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; siemens_ee_setup(); if (draco_read_eeprom() < 0) diff --git a/common/board_f.c b/common/board_f.c index 29e185137ad..1935b1dd11b 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -1006,7 +1006,7 @@ static const init_fnc_t init_sequence_f[] = { void board_init_f(ulong boot_flags) { gd->flags = boot_flags; - gd->have_console = 0; + gd->flags &= ~GD_FLG_HAVE_CONSOLE; if (initcall_run_list(init_sequence_f)) hang(); diff --git a/common/console.c b/common/console.c index 63f78004fdb..30ddefef6b1 100644 --- a/common/console.c +++ b/common/console.c @@ -586,7 +586,7 @@ int getchar(void) if (IS_ENABLED(CONFIG_DISABLE_CONSOLE) && (gd->flags & GD_FLG_DISABLE_CONSOLE)) return 0; - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) return 0; ch = console_record_getc(); @@ -607,7 +607,7 @@ int tstc(void) if (IS_ENABLED(CONFIG_DISABLE_CONSOLE) && (gd->flags & GD_FLG_DISABLE_CONSOLE)) return 0; - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) return 0; if (console_record_tstc()) @@ -715,7 +715,7 @@ void putc(const char c) if (IS_ENABLED(CONFIG_DISABLE_CONSOLE) && (gd->flags & GD_FLG_DISABLE_CONSOLE)) return; - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) return pre_console_putc(c); if (gd->flags & GD_FLG_DEVINIT) { @@ -759,7 +759,7 @@ void puts(const char *s) if (IS_ENABLED(CONFIG_DISABLE_CONSOLE) && (gd->flags & GD_FLG_DISABLE_CONSOLE)) return; - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) return pre_console_puts(s); if (gd->flags & GD_FLG_DEVINIT) { @@ -793,7 +793,7 @@ void flush(void) if (IS_ENABLED(CONFIG_DISABLE_CONSOLE) && (gd->flags & GD_FLG_DISABLE_CONSOLE)) return; - if (!gd->have_console) + if (!(gd->flags & GD_FLG_HAVE_CONSOLE)) return; if (gd->flags & GD_FLG_DEVINIT) { @@ -872,7 +872,7 @@ static int ctrlc_disabled = 0; /* see disable_ctrl() */ static int ctrlc_was_pressed = 0; int ctrlc(void) { - if (!ctrlc_disabled && gd->have_console) { + if (!ctrlc_disabled && (gd->flags & GD_FLG_HAVE_CONSOLE)) { if (tstc()) { switch (getchar()) { case 0x03: /* ^C - Control C */ @@ -1011,7 +1011,7 @@ int console_announce_r(void) /* Called before relocation - use serial functions */ int console_init_f(void) { - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; console_update_silent(); diff --git a/common/spl/spl.c b/common/spl/spl.c index 7794ddccade..de34fb06548 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -832,7 +832,7 @@ void preloader_console_init(void) serial_init(); /* serial communications setup */ - gd->have_console = 1; + gd->flags |= GD_FLG_HAVE_CONSOLE; #if CONFIG_IS_ENABLED(BANNER_PRINT) puts("\nU-Boot " SPL_TPL_NAME " " PLAIN_VERSION " (" U_BOOT_DATE " - " diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index af568e99f47..f98d821e085 100644 --- a/include/asm-generic/global_data.h +++ b/include/asm-generic/global_data.h @@ -92,15 +92,6 @@ struct global_data { */ unsigned long board_type; #endif - /** - * @have_console: console is available - * - * A value of 1 indicates that serial_init() was called and a console - * is available. - * A value of 0 indicates that console input and output drivers shall - * not be called. - */ - unsigned long have_console; #if CONFIG_IS_ENABLED(PRE_CONSOLE_BUFFER) /** * @precon_buf_idx: pre-console buffer index @@ -219,7 +210,7 @@ struct global_data { #endif #ifdef CONFIG_TIMER /** - * @timer: timer instance for Driver Model +s * @timer: timer instance for Driver Model */ struct udevice *timer; #endif @@ -690,6 +681,12 @@ enum gd_flags { * @GD_FLG_HUSH_MODERN_PARSER: Use hush 2021 parser. */ GD_FLG_HUSH_MODERN_PARSER = 0x2000000, + /** + * @GD_FLG_HAVE_CONSOLE: serial_init() was called and a console + * is available. When not set, indicates that console input and output + * drivers shall not be called. + */ + GD_FLG_HAVE_CONSOLE = 0x4000000, }; #endif /* __ASSEMBLY__ */
We don't need a full word for this boolean value. Convert it into a flag to save space in global_data. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- arch/arm/mach-exynos/spl_boot.c | 2 +- arch/arm/mach-k3/common.c | 2 +- arch/arm/mach-k3/r5/sysfw-loader.c | 2 +- board/siemens/common/board_am335x.c | 2 +- common/board_f.c | 2 +- common/console.c | 14 +++++++------- common/spl/spl.c | 2 +- include/asm-generic/global_data.h | 17 +++++++---------- 9 files changed, 21 insertions(+), 24 deletions(-)