diff mbox series

[1/1] Makefile: don't add -Wno-maybe-uninitialized twice

Message ID 20240416073524.25764-1-heinrich.schuchardt@canonical.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [1/1] Makefile: don't add -Wno-maybe-uninitialized twice | expand

Commit Message

Heinrich Schuchardt April 16, 2024, 7:35 a.m. UTC
Avoid adding the same flag to KBUILD_CFLAGS twice.

Fixes: 8602d97ca2cf ("Makefile: avoid false positive -Wmaybe-uninitialized")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Quentin Schulz April 22, 2024, 9:38 a.m. UTC | #1
Hi Heinrich,

On 4/16/24 09:35, Heinrich Schuchardt wrote:
> Avoid adding the same flag to KBUILD_CFLAGS twice.
> 
> Fixes: 8602d97ca2cf ("Makefile: avoid false positive -Wmaybe-uninitialized")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Thanks,
Quentin
Tom Rini April 29, 2024, 11:03 p.m. UTC | #2
On Tue, 16 Apr 2024 09:35:24 +0200, Heinrich Schuchardt wrote:

> Avoid adding the same flag to KBUILD_CFLAGS twice.
> 
> 

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 7321fe1499e..47f3ec82b87 100644
--- a/Makefile
+++ b/Makefile
@@ -717,7 +717,7 @@  KBUILD_CFLAGS	+= -O2
 endif
 
 ifdef CONFIG_CC_OPTIMIZE_FOR_DEBUG
-KBUILD_CFLAGS	+= -Og -Wno-maybe-uninitialized
+KBUILD_CFLAGS	+= -Og
 # Avoid false positives -Wmaybe-uninitialized
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394
 KBUILD_CFLAGS	+= -Wno-maybe-uninitialized