| Message ID | 20240331202921.262323-15-jonas@kwiboo.se |
|---|---|
| State | Changes Requested |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs | expand |
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: > The SCLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. > > Add simple support to get rate of SCLK_USB3OTGx_REF clocks to fix > reference clock period configuration. > > Also replace use of 24000000 with the OSC_HZ constant. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Thanks, Quentin
On 2024/4/1 04:28, Jonas Karlman wrote: > The SCLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. > > Add simple support to get rate of SCLK_USB3OTGx_REF clocks to fix > reference clock period configuration. > > Also replace use of 24000000 with the OSC_HZ constant. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > drivers/clk/rockchip/clk_rk3399.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c > index 29b01abeca06..6408c5d0aa6a 100644 > --- a/drivers/clk/rockchip/clk_rk3399.c > +++ b/drivers/clk/rockchip/clk_rk3399.c > @@ -956,7 +956,9 @@ static ulong rk3399_clk_get_rate(struct clk *clk) > case SCLK_UART1: > case SCLK_UART2: > case SCLK_UART3: > - return 24000000; > + case SCLK_USB3OTG0_REF: > + case SCLK_USB3OTG1_REF: > + return OSC_HZ; > case PCLK_HDMI_CTRL: > break; > case DCLK_VOP0:
diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c index 29b01abeca06..6408c5d0aa6a 100644 --- a/drivers/clk/rockchip/clk_rk3399.c +++ b/drivers/clk/rockchip/clk_rk3399.c @@ -956,7 +956,9 @@ static ulong rk3399_clk_get_rate(struct clk *clk) case SCLK_UART1: case SCLK_UART2: case SCLK_UART3: - return 24000000; + case SCLK_USB3OTG0_REF: + case SCLK_USB3OTG1_REF: + return OSC_HZ; case PCLK_HDMI_CTRL: break; case DCLK_VOP0:
The SCLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of SCLK_USB3OTGx_REF clocks to fix reference clock period configuration. Also replace use of 24000000 with the OSC_HZ constant. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- drivers/clk/rockchip/clk_rk3399.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)