| Message ID | 20240329190224.3613471-16-jonas@kwiboo.se |
|---|---|
| State | Superseded |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: rk35xx: Miscellaneous fixes and updates | expand |
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: > Add .dtb-file entry to Makefile and enable Kconfig options required to > configure pinctrl in SPL. Also add missing PHY_ROCKCHIP_NANENG_COMBOPHY. > > Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > --- > arch/arm/dts/Makefile | 1 + > configs/toybrick-rk3588_defconfig | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index f49b7e5d251f..3e0bad8306b5 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -207,6 +207,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3588) += \ > rk3588-quartzpro64.dtb \ > rk3588s-rock-5a.dtb \ > rk3588-rock-5b.dtb \ > + rk3588-toybrick-x0.dts \ Should be .dtb here I guess :) Cheers, Quentin
Hi Quentin, On 2024-04-02 12:28, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: >> Add .dtb-file entry to Makefile and enable Kconfig options required to >> configure pinctrl in SPL. Also add missing PHY_ROCKCHIP_NANENG_COMBOPHY. >> >> Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se> >> --- >> arch/arm/dts/Makefile | 1 + >> configs/toybrick-rk3588_defconfig | 5 ++++- >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile >> index f49b7e5d251f..3e0bad8306b5 100644 >> --- a/arch/arm/dts/Makefile >> +++ b/arch/arm/dts/Makefile >> @@ -207,6 +207,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3588) += \ >> rk3588-quartzpro64.dtb \ >> rk3588s-rock-5a.dtb \ >> rk3588-rock-5b.dtb \ >> + rk3588-toybrick-x0.dts \ > > Should be .dtb here I guess :) Hehe, my bad, will fix in v2 :-) Regards, Jonas > > Cheers, > Quentin
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index f49b7e5d251f..3e0bad8306b5 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -207,6 +207,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3588) += \ rk3588-quartzpro64.dtb \ rk3588s-rock-5a.dtb \ rk3588-rock-5b.dtb \ + rk3588-toybrick-x0.dts \ rk3588-turing-rk1.dtb dtb-$(CONFIG_ROCKCHIP_RV1108) += \ diff --git a/configs/toybrick-rk3588_defconfig b/configs/toybrick-rk3588_defconfig index 38fc7906eef2..0168e014103e 100644 --- a/configs/toybrick-rk3588_defconfig +++ b/configs/toybrick-rk3588_defconfig @@ -33,8 +33,9 @@ CONFIG_CMD_REGULATOR=y # CONFIG_SPL_DOS_PARTITION is not set CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIVE=y -CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_REGMAP=y CONFIG_SPL_SYSCON=y CONFIG_SPL_CLK=y @@ -53,6 +54,8 @@ CONFIG_PHY_REALTEK=y CONFIG_DWC_ETH_QOS=y CONFIG_DWC_ETH_QOS_ROCKCHIP=y CONFIG_PHY_ROCKCHIP_INNO_USB2=y +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y +CONFIG_SPL_PINCTRL=y CONFIG_PWM_ROCKCHIP=y CONFIG_SPL_RAM=y CONFIG_BAUDRATE=1500000
Add .dtb-file entry to Makefile and enable Kconfig options required to configure pinctrl in SPL. Also add missing PHY_ROCKCHIP_NANENG_COMBOPHY. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- arch/arm/dts/Makefile | 1 + configs/toybrick-rk3588_defconfig | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-)