diff mbox series

stm32mp2: Fix CONFIG_STM32MP25X flag usage

Message ID 20240109140018.2015396-1-patrice.chotard@foss.st.com
State Accepted
Commit 8a4d098bb0859b3a26c9e1100ed08d7bd1f8ed30
Delegated to: Patrice Chotard
Headers show
Series stm32mp2: Fix CONFIG_STM32MP25X flag usage | expand

Commit Message

Patrice CHOTARD Jan. 9, 2024, 2 p.m. UTC
"#if" was used instead of "#ifdef"

Fixes: 01a701994b05 ("stm32mp2: initial support")
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 arch/arm/mach-stm32mp/include/mach/stm32.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Patrick Delaunay Jan. 19, 2024, 2:45 p.m. UTC | #1
Hi

On 1/9/24 15:00, Patrice Chotard wrote:
> "#if" was used instead of "#ifdef"
>
> Fixes: 01a701994b05 ("stm32mp2: initial support")
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   arch/arm/mach-stm32mp/include/mach/stm32.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h
> index 46d469881b3..175f2a88490 100644
> --- a/arch/arm/mach-stm32mp/include/mach/stm32.h
> +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
> @@ -157,7 +157,7 @@ enum forced_boot_mode {
>   #endif /* __ASSEMBLY__ */
>   #endif /* CONFIG_STM32MP15X || CONFIG_STM32MP13X */
>   
> -#if CONFIG_STM32MP25X
> +#ifdef CONFIG_STM32MP25X
>   #define STM32_RCC_BASE			0x44200000
>   #define STM32_TAMP_BASE			0x46010000
>   


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrice CHOTARD Jan. 19, 2024, 2:50 p.m. UTC | #2
On 1/19/24 15:45, Patrick DELAUNAY wrote:
> Hi
> 
> On 1/9/24 15:00, Patrice Chotard wrote:
>> "#if" was used instead of "#ifdef"
>>
>> Fixes: 01a701994b05 ("stm32mp2: initial support")
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/mach-stm32mp/include/mach/stm32.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h
>> index 46d469881b3..175f2a88490 100644
>> --- a/arch/arm/mach-stm32mp/include/mach/stm32.h
>> +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
>> @@ -157,7 +157,7 @@ enum forced_boot_mode {
>>   #endif /* __ASSEMBLY__ */
>>   #endif /* CONFIG_STM32MP15X || CONFIG_STM32MP13X */
>>   -#if CONFIG_STM32MP25X
>> +#ifdef CONFIG_STM32MP25X
>>   #define STM32_RCC_BASE            0x44200000
>>   #define STM32_TAMP_BASE            0x46010000
>>   
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
Applied to u-boot-stm32/master

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h
index 46d469881b3..175f2a88490 100644
--- a/arch/arm/mach-stm32mp/include/mach/stm32.h
+++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
@@ -157,7 +157,7 @@  enum forced_boot_mode {
 #endif /* __ASSEMBLY__ */
 #endif /* CONFIG_STM32MP15X || CONFIG_STM32MP13X */
 
-#if CONFIG_STM32MP25X
+#ifdef CONFIG_STM32MP25X
 #define STM32_RCC_BASE			0x44200000
 #define STM32_TAMP_BASE			0x46010000