diff mbox series

[v1] arm: dts: meson: add NAND controller node for AXG

Message ID 20231130122712.189700-1-avkrasnov@salutedevices.com
State New
Delegated to: Neil Armstrong
Headers show
Series [v1] arm: dts: meson: add NAND controller node for AXG | expand

Commit Message

Arseniy Krasnov Nov. 30, 2023, 12:27 p.m. UTC
Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
---
 arch/arm/dts/meson-axg.dtsi | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

Comments

Neil Armstrong Dec. 12, 2023, 2:03 p.m. UTC | #1
Hi,

On 30/11/2023 13:27, Arseniy Krasnov wrote:

Can you add a reference to the Linux patches that you submitted so
we know it will be safe to sync the DT from Linux when they are merged ?

Thanks,
Neil

> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
> ---
>   arch/arm/dts/meson-axg.dtsi | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-axg.dtsi b/arch/arm/dts/meson-axg.dtsi
> index 3f5254eeb4..c01ace3ff1 100644
> --- a/arch/arm/dts/meson-axg.dtsi
> +++ b/arch/arm/dts/meson-axg.dtsi
> @@ -430,6 +430,27 @@
>   					};
>   				};
>   
> +				nand_all_pins: nand_all_pins {
> +					mux {
> +						groups = "emmc_nand_d0",
> +							 "emmc_nand_d1",
> +							 "emmc_nand_d2",
> +							 "emmc_nand_d3",
> +							 "emmc_nand_d4",
> +							 "emmc_nand_d5",
> +							 "emmc_nand_d6",
> +							 "emmc_nand_d7",
> +							 "nand_ce0",
> +							 "nand_ale",
> +							 "nand_cle",
> +							 "nand_wen_clk",
> +							 "nand_ren_wr";
> +						function = "nand";
> +						input-enable;
> +						bias-pull-up;
> +					};
> +				};
> +
>   				emmc_ds_pins: emmc_ds {
>   					mux {
>   						groups = "emmc_ds";
> @@ -1906,6 +1927,20 @@
>   				resets = <&reset RESET_SD_EMMC_C>;
>   			};
>   
> +			nfc: nand-controller@7800 {
> +				#address-cells = <2>;
> +				#size-cells = <2>;
> +				pinctrl-0 = <&nand_all_pins>;
> +				pinctrl-names = "default";
> +				compatible = "amlogic,meson-axg-nfc";
> +				status = "okay";
> +				reg = <0x0 0x7800 0x0 0x100>,
> +				      <0x0 0x7000 0x0 0x800>;
> +				clocks = <&clkc CLKID_SD_EMMC_C>,
> +					 <&clkc CLKID_FCLK_DIV2>;
> +				clock-names = "core", "device";
> +			};
> +
>   			usb2_phy1: phy@9020 {
>   				compatible = "amlogic,meson-gxl-usb2-phy";
>   				#phy-cells = <0>;
Arseniy Krasnov Dec. 12, 2023, 2:07 p.m. UTC | #2
Hi,

On 12.12.2023 17:03, Neil Armstrong wrote:
> Hi,
> 
> On 30/11/2023 13:27, Arseniy Krasnov wrote:
> 
> Can you add a reference to the Linux patches that you submitted so
> we know it will be safe to sync the DT from Linux when they are merged ?

Sure:

https://lore.kernel.org/linux-amlogic/20230828133647.3712644-1-avkrasnov@salutedevices.com/
https://lore.kernel.org/linux-amlogic/170107314359.1083800.4264228970569502392.b4-ty@linaro.org/T/#m30d2fd46fca4f78098be19d7ec71097f98b60d29

Thanks, Arseniy

> 
> Thanks,
> Neil
> 
>> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
>> ---
>>   arch/arm/dts/meson-axg.dtsi | 35 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>
>> diff --git a/arch/arm/dts/meson-axg.dtsi b/arch/arm/dts/meson-axg.dtsi
>> index 3f5254eeb4..c01ace3ff1 100644
>> --- a/arch/arm/dts/meson-axg.dtsi
>> +++ b/arch/arm/dts/meson-axg.dtsi
>> @@ -430,6 +430,27 @@
>>                       };
>>                   };
>>   +                nand_all_pins: nand_all_pins {
>> +                    mux {
>> +                        groups = "emmc_nand_d0",
>> +                             "emmc_nand_d1",
>> +                             "emmc_nand_d2",
>> +                             "emmc_nand_d3",
>> +                             "emmc_nand_d4",
>> +                             "emmc_nand_d5",
>> +                             "emmc_nand_d6",
>> +                             "emmc_nand_d7",
>> +                             "nand_ce0",
>> +                             "nand_ale",
>> +                             "nand_cle",
>> +                             "nand_wen_clk",
>> +                             "nand_ren_wr";
>> +                        function = "nand";
>> +                        input-enable;
>> +                        bias-pull-up;
>> +                    };
>> +                };
>> +
>>                   emmc_ds_pins: emmc_ds {
>>                       mux {
>>                           groups = "emmc_ds";
>> @@ -1906,6 +1927,20 @@
>>                   resets = <&reset RESET_SD_EMMC_C>;
>>               };
>>   +            nfc: nand-controller@7800 {
>> +                #address-cells = <2>;
>> +                #size-cells = <2>;
>> +                pinctrl-0 = <&nand_all_pins>;
>> +                pinctrl-names = "default";
>> +                compatible = "amlogic,meson-axg-nfc";
>> +                status = "okay";
>> +                reg = <0x0 0x7800 0x0 0x100>,
>> +                      <0x0 0x7000 0x0 0x800>;
>> +                clocks = <&clkc CLKID_SD_EMMC_C>,
>> +                     <&clkc CLKID_FCLK_DIV2>;
>> +                clock-names = "core", "device";
>> +            };
>> +
>>               usb2_phy1: phy@9020 {
>>                   compatible = "amlogic,meson-gxl-usb2-phy";
>>                   #phy-cells = <0>;
>
diff mbox series

Patch

diff --git a/arch/arm/dts/meson-axg.dtsi b/arch/arm/dts/meson-axg.dtsi
index 3f5254eeb4..c01ace3ff1 100644
--- a/arch/arm/dts/meson-axg.dtsi
+++ b/arch/arm/dts/meson-axg.dtsi
@@ -430,6 +430,27 @@ 
 					};
 				};
 
+				nand_all_pins: nand_all_pins {
+					mux {
+						groups = "emmc_nand_d0",
+							 "emmc_nand_d1",
+							 "emmc_nand_d2",
+							 "emmc_nand_d3",
+							 "emmc_nand_d4",
+							 "emmc_nand_d5",
+							 "emmc_nand_d6",
+							 "emmc_nand_d7",
+							 "nand_ce0",
+							 "nand_ale",
+							 "nand_cle",
+							 "nand_wen_clk",
+							 "nand_ren_wr";
+						function = "nand";
+						input-enable;
+						bias-pull-up;
+					};
+				};
+
 				emmc_ds_pins: emmc_ds {
 					mux {
 						groups = "emmc_ds";
@@ -1906,6 +1927,20 @@ 
 				resets = <&reset RESET_SD_EMMC_C>;
 			};
 
+			nfc: nand-controller@7800 {
+				#address-cells = <2>;
+				#size-cells = <2>;
+				pinctrl-0 = <&nand_all_pins>;
+				pinctrl-names = "default";
+				compatible = "amlogic,meson-axg-nfc";
+				status = "okay";
+				reg = <0x0 0x7800 0x0 0x100>,
+				      <0x0 0x7000 0x0 0x800>;
+				clocks = <&clkc CLKID_SD_EMMC_C>,
+					 <&clkc CLKID_FCLK_DIV2>;
+				clock-names = "core", "device";
+			};
+
 			usb2_phy1: phy@9020 {
 				compatible = "amlogic,meson-gxl-usb2-phy";
 				#phy-cells = <0>;