| Message ID | 20231027134630.244886-2-rogerq@kernel.org |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | arm: dts: k3-am6: Fix Ethernet/DMA | expand |
On Fri, 2023-10-27 at 16:46 +0300, Roger Quadros wrote: > From: Siddharth Vadapalli <s-vadapalli@ti.com> > > Update main_bcdma and main_pktdma nodes for native configuration in the > absence of DM services. > > Reported-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > index b78d34b459..7186f0830f 100644 > --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi > +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > @@ -154,6 +154,33 @@ > bootph-all; > }; > > +&main_bcdma { > + reg = <0x00 0x485c0100 0x00 0x100>, > + <0x00 0x4c000000 0x00 0x20000>, > + <0x00 0x4a820000 0x00 0x20000>, > + <0x00 0x4aa40000 0x00 0x20000>, > + <0x00 0x4bc00000 0x00 0x100000>, > + <0x00 0x48600000 0x00 0x8000>, > + <0x00 0x484a4000 0x00 0x2000>, > + <0x00 0x484c2000 0x00 0x2000>; > + reg-names = "gcfg", "bchanrt", "rchanrt", "tchanrt", > + "ringrt" , "cfg", "tchan", "rchan"; > +}; > + > +&main_pktdma { > + bootph-all; I believe that property would usually be added as the last item of a node. > + reg = <0x00 0x485c0000 0x00 0x100>, > + <0x00 0x4a800000 0x00 0x20000>, > + <0x00 0x4aa00000 0x00 0x20000>, > + <0x00 0x4b800000 0x00 0x200000>, > + <0x00 0x485e0000 0x00 0x10000>, > + <0x00 0x484a0000 0x00 0x2000>, > + <0x00 0x484c0000 0x00 0x2000>, > + <0x00 0x48430000 0x00 0x1000>; > + reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt", > + "cfg", "tchan", "rchan", "rflow"; > +}; > + > &cpsw3g { > bootph-all; > ethernet-ports {
On 28/10/2023 11:10, Marcel Ziswiler wrote: > On Fri, 2023-10-27 at 16:46 +0300, Roger Quadros wrote: >> From: Siddharth Vadapalli <s-vadapalli@ti.com> >> >> Update main_bcdma and main_pktdma nodes for native configuration in the >> absence of DM services. >> >> Reported-by: Nishanth Menon <nm@ti.com> >> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- >> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> index b78d34b459..7186f0830f 100644 >> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> @@ -154,6 +154,33 @@ >> bootph-all; >> }; >> >> +&main_bcdma { >> + reg = <0x00 0x485c0100 0x00 0x100>, >> + <0x00 0x4c000000 0x00 0x20000>, >> + <0x00 0x4a820000 0x00 0x20000>, >> + <0x00 0x4aa40000 0x00 0x20000>, >> + <0x00 0x4bc00000 0x00 0x100000>, >> + <0x00 0x48600000 0x00 0x8000>, >> + <0x00 0x484a4000 0x00 0x2000>, >> + <0x00 0x484c2000 0x00 0x2000>; >> + reg-names = "gcfg", "bchanrt", "rchanrt", "tchanrt", >> + "ringrt" , "cfg", "tchan", "rchan"; >> +}; >> + >> +&main_pktdma { >> + bootph-all; > > I believe that property would usually be added as the last item of a node. OK. I'll move it to the end. Thanks. > >> + reg = <0x00 0x485c0000 0x00 0x100>, >> + <0x00 0x4a800000 0x00 0x20000>, >> + <0x00 0x4aa00000 0x00 0x20000>, >> + <0x00 0x4b800000 0x00 0x200000>, >> + <0x00 0x485e0000 0x00 0x10000>, >> + <0x00 0x484a0000 0x00 0x2000>, >> + <0x00 0x484c0000 0x00 0x2000>, >> + <0x00 0x48430000 0x00 0x1000>; >> + reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt", >> + "cfg", "tchan", "rchan", "rflow"; >> +}; >> + >> &cpsw3g { >> bootph-all; >> ethernet-ports {
diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index b78d34b459..7186f0830f 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi @@ -154,6 +154,33 @@ bootph-all; }; +&main_bcdma { + reg = <0x00 0x485c0100 0x00 0x100>, + <0x00 0x4c000000 0x00 0x20000>, + <0x00 0x4a820000 0x00 0x20000>, + <0x00 0x4aa40000 0x00 0x20000>, + <0x00 0x4bc00000 0x00 0x100000>, + <0x00 0x48600000 0x00 0x8000>, + <0x00 0x484a4000 0x00 0x2000>, + <0x00 0x484c2000 0x00 0x2000>; + reg-names = "gcfg", "bchanrt", "rchanrt", "tchanrt", + "ringrt" , "cfg", "tchan", "rchan"; +}; + +&main_pktdma { + bootph-all; + reg = <0x00 0x485c0000 0x00 0x100>, + <0x00 0x4a800000 0x00 0x20000>, + <0x00 0x4aa00000 0x00 0x20000>, + <0x00 0x4b800000 0x00 0x200000>, + <0x00 0x485e0000 0x00 0x10000>, + <0x00 0x484a0000 0x00 0x2000>, + <0x00 0x484c0000 0x00 0x2000>, + <0x00 0x48430000 0x00 0x1000>; + reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt", + "cfg", "tchan", "rchan", "rflow"; +}; + &cpsw3g { bootph-all; ethernet-ports {