diff mbox series

clock_imx8mm: Add a stub for imx8mp_fec_interface_init()

Message ID 20231020004735.1913081-1-festevam@gmail.com
State Accepted
Commit 458ab6b9f224f2dc36a6203a2eddb98445309b0e
Delegated to: Stefano Babic
Headers show
Series clock_imx8mm: Add a stub for imx8mp_fec_interface_init() | expand

Commit Message

Fabio Estevam Oct. 20, 2023, 12:47 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

When CONFIG_DWC_ETH_QOS_IMX=y and CONFIG_FEC_MXC is not selected, the
following warning is seen: 

arch/arm/mach-imx/imx8m/clock_imx8mm.c: In function 'board_interface_eth_init':
arch/arm/mach-imx/imx8m/clock_imx8mm.c:914:24: warning: implicit declaration of function 'imx8mp_fec_interface_init; did you mean 'imx8mp_eqos_interface_init'? [-Wimplicit-function-declaration]

Fix it by adding a stub for imx8mp_fec_interface_init() to handle this
case.

This follows the same approach done on imx8mp_eqos_interface_init().

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/mach-imx/imx8m/clock_imx8mm.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Marek Vasut Oct. 20, 2023, 4:17 a.m. UTC | #1 
On 10/20/23 02:47, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> When CONFIG_DWC_ETH_QOS_IMX=y and CONFIG_FEC_MXC is not selected, the
> following warning is seen:
> 
> arch/arm/mach-imx/imx8m/clock_imx8mm.c: In function 'board_interface_eth_init':
> arch/arm/mach-imx/imx8m/clock_imx8mm.c:914:24: warning: implicit declaration of function 'imx8mp_fec_interface_init; did you mean 'imx8mp_eqos_interface_init'? [-Wimplicit-function-declaration]
> 
> Fix it by adding a stub for imx8mp_fec_interface_init() to handle this
> case.
> 
> This follows the same approach done on imx8mp_eqos_interface_init().
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marek Vasut <marex@denx.de>
Fabio Estevam Dec. 13, 2023, 4:29 p.m. UTC | #2 
On Thu, Oct 19, 2023 at 9:47 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> When CONFIG_DWC_ETH_QOS_IMX=y and CONFIG_FEC_MXC is not selected, the
> following warning is seen:
>
> arch/arm/mach-imx/imx8m/clock_imx8mm.c: In function 'board_interface_eth_init':
> arch/arm/mach-imx/imx8m/clock_imx8mm.c:914:24: warning: implicit declaration of function 'imx8mp_fec_interface_init; did you mean 'imx8mp_eqos_interface_init'? [-Wimplicit-function-declaration]
>
> Fix it by adding a stub for imx8mp_fec_interface_init() to handle this
> case.
>
> This follows the same approach done on imx8mp_eqos_interface_init().
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to u-boot-imx next, thanks.
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
index 986870799d36..5cf97a5ea952 100644
--- a/arch/arm/mach-imx/imx8m/clock_imx8mm.c
+++ b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
@@ -904,6 +904,13 @@  static int imx8mp_fec_interface_init(struct udevice *dev,
 
 	return 0;
 }
+#else
+static int imx8mp_fec_interface_init(struct udevice *dev,
+				     phy_interface_t interface_type,
+				     bool mx8mp)
+{
+	return 0;
+}
 #endif
 
 int board_interface_eth_init(struct udevice *dev, phy_interface_t interface_type)