Message ID | 20231018175413.1236767-1-festevam@gmail.com |
---|---|
State | Superseded |
Delegated to: | Stefano Babic |
Headers | show |
Series | [v2] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells | expand |
On 10/18/23 19:54, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Pass #address-cells/size-cells in the mdio node to avoid the following > DTC warning: > > DTCO arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo > Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #address-cells value > Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #size-cells value > > Signed-off-by: Fabio Estevam <festevam@denx.de> > Reviewed-by: Marek Vasut <marex@denx.de> > --- > Changes since v1: > - Remove the ethphy0g label. (Marek) > > arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > index f27e6429abe4..bad015536166 100644 > --- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > +++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > @@ -5,6 +5,13 @@ > /dts-v1/; > /plugin/; > > -ðphy0g { > - reg = <7>; > +&eqos { > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@7 { One more thing to fix, this should be ethernet-phy@5 , not ethernet-phy@7 . This is a local fix up for old hardware, which overrides the PHY MDIO address, see: arch/arm/dts/imx8mp-dhcom-som.dtsi: ethphy0g: ethernet-phy@5 { /* Micrel KSZ9131RNXI */
diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts index f27e6429abe4..bad015536166 100644 --- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts +++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts @@ -5,6 +5,13 @@ /dts-v1/; /plugin/; -ðphy0g { - reg = <7>; +&eqos { + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethernet-phy@7 { + reg = <7>; + }; + }; };