Message ID | 20231007215648.3156877-3-festevam@gmail.com |
---|---|
State | Superseded |
Delegated to: | Stefano Babic |
Headers | show |
Series | [1/3] usb: ehci: mxs: Fix the USB node pointer retrieval | expand |
On 10/7/23 23:56, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Select the USB options to allow running "ums 0 mmc 0". > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > configs/mx28evk_defconfig | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/configs/mx28evk_defconfig b/configs/mx28evk_defconfig > index df0cceaea719..15cc99684c05 100644 > --- a/configs/mx28evk_defconfig > +++ b/configs/mx28evk_defconfig > @@ -32,6 +32,9 @@ CONFIG_CMD_DM=y > CONFIG_CMD_GPIO=y > CONFIG_CMD_MMC=y > CONFIG_CMD_NAND_TRIMFFS=y > +CONFIG_CMD_USB=y > +CONFIG_CMD_USB_SDP=y This seems to be doing more than just enabling UMS, right ? SDP is enabled too, but not mentioned in commit message. > +CONFIG_CMD_USB_MASS_STORAGE=y > CONFIG_CMD_CACHE=y > CONFIG_CMD_DATE=y > CONFIG_CMD_EXT4=y > @@ -65,3 +68,14 @@ CONFIG_RTC_MXS=y > CONFIG_DM_SERIAL=y > CONFIG_SPI=y > CONFIG_USB=y > +CONFIG_SPL_USB_HOST=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_MAX_CONTROLLER_COUNT=2 > +CONFIG_USB_GADGET=y > +CONFIG_SPL_USB_GADGET=y This SPL USB gadget is not related to UMS either . Please fix, either document the full amount of changes, or drop unrelated changes. [...]
diff --git a/configs/mx28evk_defconfig b/configs/mx28evk_defconfig index df0cceaea719..15cc99684c05 100644 --- a/configs/mx28evk_defconfig +++ b/configs/mx28evk_defconfig @@ -32,6 +32,9 @@ CONFIG_CMD_DM=y CONFIG_CMD_GPIO=y CONFIG_CMD_MMC=y CONFIG_CMD_NAND_TRIMFFS=y +CONFIG_CMD_USB=y +CONFIG_CMD_USB_SDP=y +CONFIG_CMD_USB_MASS_STORAGE=y CONFIG_CMD_CACHE=y CONFIG_CMD_DATE=y CONFIG_CMD_EXT4=y @@ -65,3 +68,14 @@ CONFIG_RTC_MXS=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_USB=y +CONFIG_SPL_USB_HOST=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_MAX_CONTROLLER_COUNT=2 +CONFIG_USB_GADGET=y +CONFIG_SPL_USB_GADGET=y +CONFIG_USB_GADGET_MANUFACTURER="FSL" +CONFIG_USB_GADGET_VENDOR_NUM=0x0525 +CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 +CONFIG_CI_UDC=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_SPL_USB_SDP_SUPPORT=y