diff mbox series

[v3,3/3] X86: pxeboot: bugfix: Set variable for size of initrd

Message ID 20230504134255.8510-4-thomas.mittelstaedt@de.bosch.com
State Accepted
Commit 1a075d4e0de797ac2b25adcc27ea537fa01f89cb
Delegated to: Bin Meng
Headers show
Series Enable U-Boot at Virtualbox to boot images | expand

Commit Message

Mittelstaedt Thomas (XC-CT/EBV3) May 4, 2023, 1:42 p.m. UTC 
From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>

The problem was, that zboot() didn't work because of missing
ramdisc size.

Signed-off-by: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
---
 boot/pxe_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass May 5, 2023, 12:40 a.m. UTC | #1 
On Thu, 4 May 2023 at 07:43, <thomas.mittelstaedt@de.bosch.com> wrote:
>
> From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
>
> The problem was, that zboot() didn't work because of missing
> ramdisc size.
>
> Signed-off-by: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> ---
>  boot/pxe_utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Fixes: 085cbdafca9 ("pxe: simplify label_boot()")
Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass Aug. 10, 2023, 9:33 p.m. UTC | #2 
Hi Bin,

On Thu, 4 May 2023 at 18:40, Simon Glass <sjg@chromium.org> wrote:
>
> On Thu, 4 May 2023 at 07:43, <thomas.mittelstaedt@de.bosch.com> wrote:
> >
> > From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> >
> > The problem was, that zboot() didn't work because of missing
> > ramdisc size.
> >
> > Signed-off-by: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > ---
> >  boot/pxe_utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Fixes: 085cbdafca9 ("pxe: simplify label_boot()")
> Reviewed-by: Simon Glass <sjg@chromium.org>

This patch and some others seem to have been lost. Can you please check here?

https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=&archive=&delegate=56520

Regards,
Simon
Bin Meng Aug. 11, 2023, 12:26 p.m. UTC | #3 
Hi Simon,

On Fri, Aug 11, 2023 at 5:33 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Bin,
>
> On Thu, 4 May 2023 at 18:40, Simon Glass <sjg@chromium.org> wrote:
> >
> > On Thu, 4 May 2023 at 07:43, <thomas.mittelstaedt@de.bosch.com> wrote:
> > >
> > > From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > >
> > > The problem was, that zboot() didn't work because of missing
> > > ramdisc size.
> > >
> > > Signed-off-by: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > > ---
> > >  boot/pxe_utils.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > Fixes: 085cbdafca9 ("pxe: simplify label_boot()")
> > Reviewed-by: Simon Glass <sjg@chromium.org>
>
> This patch and some others seem to have been lost. Can you please check here?
>
> https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=&archive=&delegate=56520
>

Indeed I missed these. Will take a look soon.

Regards,
Bin
Bin Meng Aug. 11, 2023, 3:18 p.m. UTC | #4 
Hi Thomas, Simon,

On Fri, Aug 11, 2023 at 8:26 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Fri, Aug 11, 2023 at 5:33 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Bin,
> >
> > On Thu, 4 May 2023 at 18:40, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > On Thu, 4 May 2023 at 07:43, <thomas.mittelstaedt@de.bosch.com> wrote:
> > > >
> > > > From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > > >
> > > > The problem was, that zboot() didn't work because of missing
> > > > ramdisc size.
> > > >
> > > > Signed-off-by: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > > > ---
> > > >  boot/pxe_utils.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> > > Fixes: 085cbdafca9 ("pxe: simplify label_boot()")
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > This patch and some others seem to have been lost. Can you please check here?
> >
> > https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=&archive=&delegate=56520
> >
>
> Indeed I missed these. Will take a look soon.
>

I have rebased this series on top of u-boot/master and pushed this to
u-boot-x86/master.

Would you please post a patch to efi-payload doc to describe how to
test this with Virtual Box? Thanks!

Regards,
Bin
Mittelstaedt Thomas (XC-CT/EBV3) Aug. 16, 2023, 1:06 p.m. UTC | #5 
Hi Bin,

I have never done this. Can you give me some hints:

- Base version of U-boot
- Path and filename for "efi-payload doc"
- Some info about format of doc file and /or example to have a look for

Mit freundlichen Grüßen / Best regards

Thomas Mittelstaedt

Cross-Domain Computing Solutions, Engineering BBM Vehicle Computer 3 (XC-CT/EBV3)
Robert Bosch GmbH | Postfach 10 02 61 | 31102 Hildesheim | GERMANY | www.bosch.com
Tel. +49 5121 49-2965 | Mobil +49 160 90418883 | Telefax +49 711 811-5052965 | Thomas.Mittelstaedt@de.bosch.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000;
Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, 
Dr. Christian Fischer, Dr. Markus Forschner, Stefan Grosch, Dr. Markus Heyn, Dr. Tanja Rückert

> -----Ursprüngliche Nachricht-----
> Von: Bin Meng <bmeng.cn@gmail.com>
> Gesendet: Freitag, 11. August 2023 17:18
> An: Simon Glass <sjg@chromium.org>
> Cc: Mittelstaedt Thomas (XC-CT/EBV3) <thomas.mittelstaedt@de.bosch.com>;
> u-boot@lists.denx.de; Niel Armstrong <neil.armstrong@linaro.org>; Patrick
> Delaunay <patrick.delaunay@foss.st.com>; Ramon Fried
> <rfried.dev@gmail.com>; Marek Vasut <marex@denx.de>; Manuel Traut
> <manuel.traut@mt.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Betreff: Re: [PATCH v3 3/3] X86: pxeboot: bugfix: Set variable for size of initrd
> 
> Hi Thomas, Simon,
> 
> On Fri, Aug 11, 2023 at 8:26 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Fri, Aug 11, 2023 at 5:33 AM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Bin,
> > >
> > > On Thu, 4 May 2023 at 18:40, Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > On Thu, 4 May 2023 at 07:43, <thomas.mittelstaedt@de.bosch.com> wrote:
> > > > >
> > > > > From: Thomas Mittelstaedt <thomas.mittelstaedt@de.bosch.com>
> > > > >
> > > > > The problem was, that zboot() didn't work because of missing
> > > > > ramdisc size.
> > > > >
> > > > > Signed-off-by: Thomas Mittelstaedt
> > > > > <thomas.mittelstaedt@de.bosch.com>
> > > > > ---
> > > > >  boot/pxe_utils.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > >
> > > > Fixes: 085cbdafca9 ("pxe: simplify label_boot()")
> > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > >
> > > This patch and some others seem to have been lost. Can you please check
> here?
> > >
> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > >
> tchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D%26submitt
> > >
> er%3D%26state%3D%26q%3D%26archive%3D%26delegate%3D56520&data=05
> %7C01
> > >
> %7Cthomas.mittelstaedt%40de.bosch.com%7C1dde215fe90f46abcc1008db9a7e
> > >
> 30a0%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638273638986309
> 018
> > >
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ
> BTiI
> > >
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b%2B9kLZEcwvj5U
> VSlAmQf
> > > 1JGhSP7EVOvnMezV4vUwqG8%3D&reserved=0
> > >
> >
> > Indeed I missed these. Will take a look soon.
> >
> 
> I have rebased this series on top of u-boot/master and pushed this to u-boot-
> x86/master.
> 
> Would you please post a patch to efi-payload doc to describe how to test this with
> Virtual Box? Thanks!
> 
> Regards,
> Bin
Bin Meng Aug. 16, 2023, 1:18 p.m. UTC | #6 
Hi Mittelstaedt,

On Wed, Aug 16, 2023 at 9:06 PM Mittelstaedt Thomas (XC-CT/EBV3)
<Thomas.Mittelstaedt@de.bosch.com> wrote:
>
> Hi Bin,
>
> I have never done this. Can you give me some hints:
>
> - Base version of U-boot
> - Path and filename for "efi-payload doc"
> - Some info about format of doc file and /or example to have a look for
>

It's doc/develop/uefi/u-boot_on_efi.rst of the u-boot/master.

The format is reST. You can add something in the example section.

Regards,
Bin
diff mbox series

Patch

diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index 3a1e50f2b1..87c32b6e62 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -554,7 +554,7 @@  static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
 			       label->name);
 			goto cleanup;
 		}
-
+		strcpy(initrd_filesize, simple_xtoa(size));
 		initrd_addr_str = env_get("ramdisk_addr_r");
 		size = snprintf(initrd_str, sizeof(initrd_str), "%s:%lx",
 				initrd_addr_str, size);