Message ID | 20230430012147.1046188-1-sjg@chromium.org |
---|---|
State | Accepted |
Commit | 36fc832927eba16b175e07c5a42b9d7ab8f5552b |
Delegated to: | Tom Rini |
Headers | show |
Series | [1/3] Makefile: Fix incorrect FORCE deps on env rules | expand |
On Sat, Apr 29, 2023 at 07:21:45PM -0600, Simon Glass wrote: > These rules run on every build even if nothing has changed. The FORCE > dependency is only needed for if_changed, not for cmd. Drop it. > > Signed-off-by: Simon Glass <sjg@chromium.org> Applied to u-boot/next, thanks!
diff --git a/Makefile b/Makefile index 166acba27032..19503d013ab6 100644 --- a/Makefile +++ b/Makefile @@ -1808,7 +1808,7 @@ quiet_cmd_gen_envp = ENVP $@ rm -f $@; \ touch $@ ; \ fi -include/generated/env.in: include/generated/env.txt FORCE +include/generated/env.in: include/generated/env.txt $(call cmd,gen_envp) # Regenerate the environment if it changes @@ -1826,7 +1826,7 @@ quiet_cmd_envc = ENVC $@ touch $@ ; \ fi -include/generated/env.txt: $(wildcard $(ENV_FILE)) FORCE +include/generated/env.txt: $(wildcard $(ENV_FILE)) $(call cmd,envc) # Write out the resulting environment, converted to a C string
These rules run on every build even if nothing has changed. The FORCE dependency is only needed for if_changed, not for cmd. Drop it. Signed-off-by: Simon Glass <sjg@chromium.org> --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)