| Message ID | 20230406161713.73321-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Commit | 04e08e3c549d065bd49e3d5c23a944a4e0da0a0a |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | arm: mx6: module_fuse: fix build failure due to wrong argument name | expand |
On 4/7/2023 12:17 AM, Giulio Benetti wrote: > nodeoff variable should be variable off returned by fdt_path_offset() so > let's rename it to off. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Hello All, On 07/04/23 03:52, Peng Fan wrote: > > > On 4/7/2023 12:17 AM, Giulio Benetti wrote: >> nodeoff variable should be variable off returned by fdt_path_offset() so >> let's rename it to off. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Reviewed-by: Peng Fan <peng.fan@nxp.com> I kindly ping Best regards
On Thu, Apr 6, 2023 at 1:17 PM Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > > nodeoff variable should be variable off returned by fdt_path_offset() so > let's rename it to off. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Reviewed-by: Fabio Estevam <festevam@denx.de>
> nodeoff variable should be variable off returned by fdt_path_offset() so > let's rename it to off. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > Reviewed-by: Peng Fan <peng.fan@nxp.com> > Reviewed-by: Fabio Estevam <festevam@denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/mach-imx/mx6/module_fuse.c b/arch/arm/mach-imx/mx6/module_fuse.c index 0f4565e311..b58f11c1e5 100644 --- a/arch/arm/mach-imx/mx6/module_fuse.c +++ b/arch/arm/mach-imx/mx6/module_fuse.c @@ -206,7 +206,7 @@ int ft_system_setup(void *blob, struct bd_info *bd) if (off < 0) continue; /* Not found, skip it */ add_status: - rc = fdt_setprop(blob, nodeoff, "status", status, + rc = fdt_setprop(blob, off, "status", status, strlen(status) + 1); if (rc) { if (rc == -FDT_ERR_NOSPACE) {
nodeoff variable should be variable off returned by fdt_path_offset() so let's rename it to off. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- arch/arm/mach-imx/mx6/module_fuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)