From patchwork Thu Apr 6 10:26:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 1765944 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-NXP1-onmicrosoft-com header.b=bil7Vzvm; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PsbwY1Ynkz1yY8 for ; Thu, 6 Apr 2023 19:36:13 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3ED6A86010; Thu, 6 Apr 2023 11:36:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bil7Vzvm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C2A9185FB3; Thu, 6 Apr 2023 11:36:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,T_SPF_PERMERROR autolearn=unavailable autolearn_force=no version=3.4.2 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1a::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7390686010 for ; Thu, 6 Apr 2023 11:36:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyIad0odnxfWoqlZECZm88xQvhYCc3gZ4QQvWs6piA7C/VgbpLj0Vg9DLXggm44x477m5vmnffWDnkmLue8xtp7EczxCexWL0o5EbX83QXhQiiiAKWQfyib6dMyvVK5JqgpOdcCwXL5HGyJZhtfz7SxNTk/rUOas4ag1eguEQM3zDksL3LDaBkIfp0ZSSWi4HCqdTz4tzVIMmN2CGRR4ASCq+rBd3yq/4A8ulFYyA3mISyoZROk+qifZYtN4721h3+H5WScVEhuWxi3D3EZLtxFi1uBV9KwCFC8TEd1ycWo51X4ifNGLMCZ+VqMWNsjILrBr9inYwygJhPYr8A1BGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XOiuKGDA2YSGhvuL8DLdkuqQMB2aIL0LuQAUodA8MbY=; b=lgp6edQximDc9JM3WEFB+oNF31mR8IHOl+oMQhCPOYN4l4BMPV/Oer+LBxl/9u835rHrq1L7v9YN7imV4lCroSnUu9w7/ZpeULQ995pbLvq3NJdtyQqu6xMioQ4cgyXMdAnBXB9ZZkTs6MuTtJILFsQ1HDDH19n1RrjyoGrmuITAit0yRo8JyrSGpnnVJyHyVWJ0n0CgdggKTAjTNvU7r63wEfVBqYXMWmKmOqXYiVrRUTJ/DrmisdtJeKMGGurr6LZ4Hd8yDUlNgevGPZOSZFNL7T2KTESv9sTEx2L2Yx/mLcpSbJKIQ5eT9om0NybG+Yh4b78Dsi8Si6/j74HRtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XOiuKGDA2YSGhvuL8DLdkuqQMB2aIL0LuQAUodA8MbY=; b=bil7VzvmGp9v9yFK+dG7E7v/wuo8xwaxr/e3w7JwfU/rDlE66bwnAornzCJjMfwwHEoXSZUKOhreX4U+OKEYoRTvbYvucwTcjVFaRAGmR9bAL7Qim2QSnxhsXhRVcY6bBR95hDVOhb5gFgz8wzAdJjPd/8IzWSQBp6PDG2CYIyY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM0PR04MB6994.eurprd04.prod.outlook.com (2603:10a6:208:188::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Thu, 6 Apr 2023 09:36:00 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4%4]) with mapi id 15.20.6254.033; Thu, 6 Apr 2023 09:36:00 +0000 From: "Peng Fan (OSS)" To: hs@denx.de Cc: u-boot@lists.denx.de, Ye Li , Peng Fan Subject: [PATCH] i2c: imx_lpi2c: Fix misuse the IS_ENABLED for DM clock Date: Thu, 6 Apr 2023 18:26:35 +0800 Message-Id: <20230406102636.18472-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.36.0 X-ClientProxiedBy: SI2PR02CA0026.apcprd02.prod.outlook.com (2603:1096:4:195::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM0PR04MB6994:EE_ X-MS-Office365-Filtering-Correlation-Id: 07a4b8f4-a300-4bee-65db-08db3682549e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: onWrvLOuCUpKYPyZYbjBdrhWGt3mxl3iKFEWFDiW9ELQW8Re8DibDeJl5yCVgTQab79CI+LKmAGVR1QUDl/3xAN6Y5PW4vZCz+AvQ3HO1fM57BCrBbXa4xPPgnkkH67gxBV/9qspzvzoHUCoX+1p2HX6eB/9ReCBgo5WON0IAYTAI8jHzb6Db/oym8aPzc9jFkq/ur2WMVzQD6dpQ7e2wWX9SIe+v/jGcO4mfAOKdTWjZuxl/UsdX32syNcqAjNRDs5eJtJwLCGQSRtUT7aaZq03M04bg7YOn68vn1lqnBhgDQDDFdDmdW7E3b43O0/azJHk6mtxEfeYyBO5ad+W3acLc6oBNVKk5YjBnrmd9zdCgCKlSA9o4YRrBKYtRqzzYHE+rrYTqUI1NFOvVMYQ2nzqNu1j8TNYxI1DhdxlAC2S0QwERq+hfm/NTJvFs43dYOL4hp4IejoKjBMga7RT57lxqIx+txjWjfHE0v/TsC1nsuAQaeYjlrsRFBxvcke2/xcpih/z1E0QboNgizme8l0OPwmuuQnu4OC5Q+DrIAM5pQswmSkv6Hqpse4C6Q5i3YmvH7BKx2KdaVUZzG09Exo61qj1EEW/Vzl7ORBxf47b/2fNsK+B7AG8PIPPIrUN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199021)(4326008)(6916009)(66476007)(66946007)(8676002)(66556008)(8936002)(5660300002)(2906002)(41300700001)(83380400001)(478600001)(54906003)(316002)(6486002)(52116002)(26005)(6666004)(6512007)(1076003)(186003)(6506007)(2616005)(38350700002)(38100700002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aPERHCfGBzLC7I+oZnl1UHqxRItx9JcCX6A3ug19yZn23r6pULHS+YSVnw3W8pHKzcvgQntzqwKOreq3wBnpeRgzJFVLGpYd3WhstKnplr3t0cYi5D65E6LEncIog49FagA2doU1JnpGZnyqGgBX3cqVIFXVxW8f+0iSg2W29FeMDAsYs5X4NNNgi/1leDf63OJe+GqKycHcP3r8GmKSjvWNWiQTVQ8Zi45NTPE8rlN4dgHbo3X1zoxBhXzXp3u7+x/SnZ67PRmDP5RjeXMBA7QsyfKlOiPdvjOm3kZ/9g5o9mfmjnK574T8cLtevFkIueBPPGegvNb0xjAyt2yRMSLKjKjmQJPuvsJ0VW9sJhT1YR1z5zBkdEFefOOGl3BmwOiMC+X/xhZS+FuGqOz/RRhIpGVQbrphHgf51ZvrElzRD3U26VuuQ6nUBDh7iYTf2w3PfGkopVi+kPmy1G84QoCwKgafKlecIb8MJ8uOFQEmTYZUjZUR22L/cEQ4JTF2mdZYT0Drb67aNSspn1xG+drB27lMW1RoHW9HCKF/jCoovEwFq0bsWKPMr5TN/HJFJCdxvuD0ZyP6b1+uNm1Z33Bwz1txO6THK7pzVbje83XHmiy0yGNet0/u+018Wv+6o/hAeNlxTLxo88EezkmjqFIoc20LLwGqoMDeYMJ4K03rJvmREIgMwbdmpFbfNbPGqhcTEOQxOlfLTjitkItvssE6zy0bsi8KyxNxEyOz8ApFrcbAsKikGmt8BcREe6AhpD7efF4QXF1NywxwxaA94QmHslLkFCd73SZzvEvwWpVndT/avWtWrXi6yueXTv47iFeZF6zdLzVo6SzZcBqZzST/Kh/gJ20lBuARZLLC6/eP5mlhEfkFZmrO/1cbmecLFLpoxxOW9FEShcONcvjPf2i6RovEKPEbDDWxp5+HqLxtuShKUfyAVXxXaTYjaKXWkgLNcThnpv9M1Tq+Ww0vhoXAfobBWBn0K66oy4cxTC4kTYBMWvgrEGvWFTu/PxKMR5rkkDYNdf3T7WRJ29lkj8iL8520OyBc9taHr3HZH9QBjlWVZMCcPjrgBwpQCD234msO5ZiZLiZOZ/dgXZLcssUN4BKEGZ8ILiefgW7K3OIAyBw5Zl8QGKMP4J05D50KAhFBIRAwD4j8MwO95dA02eFF+s3kkN3K6b+8gdoA0qQf8qyZy2SxXf98jdAcO0eelvd05jbk5kY6+od0XGlu6JpI8Nav/V35FmAVVJEziG5ljsiifDTtKl2X6invqfDwvRT0JivToi/YpmVDfZ5w1GInQLAQZkYM4GgdZ9WE6QJBw6p4CEkeVpJ9+j0M0Fh+DIsawr+BiYkiYxDPLuVohHAJUoDWS9epBoc53fzJeiGtE0NtJ1lBskoLtElrSKK3w0j2678nt1DCFqLkd9554Y+ZosWAhzKMXqIjXAmmQx2ev5dlFquldKw9EYDC5O7iaSys1wNON76Jkp+iBGJAy4UqIaIEMhgBxkdNrLhvYsqqcGAhl9sxGC+Ypo7uqogxQRjEC50qogYntZRPk5xRbJ1PmxiQ2lFJNeZlXIUgOfps2VhMUUSt52uXcQGC/Lum X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07a4b8f4-a300-4bee-65db-08db3682549e X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:36:00.4186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Q2zfpJH2EaV0SJwKDnzC1jxQkVnbj8EB+ZakxHDiApAegd2g0/R6qmmMr2xqZ/yI3k9mxOskx/6kTcn/ZAtRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6994 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Ye Li The IS_ENABLED, which does not consider SPL build, should be replaced by CONFIG_IS_ENABLED. For the case that we only enable DM CLK for u-boot but not in SPL, the IS_ENABLED(CONFIG_CLK) still returns true, then cause clock failure. Reviewed-by: Peng Fan Signed-off-by: Ye Li Signed-off-by: Peng Fan --- drivers/i2c/imx_lpi2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/imx_lpi2c.c b/drivers/i2c/imx_lpi2c.c index 92c500327b4..ad9293c92e1 100644 --- a/drivers/i2c/imx_lpi2c.c +++ b/drivers/i2c/imx_lpi2c.c @@ -282,7 +282,7 @@ static int bus_i2c_set_bus_speed(struct udevice *bus, int speed) bool mode; int i; - if (IS_ENABLED(CONFIG_CLK)) { + if (CONFIG_IS_ENABLED(CLK)) { clock_rate = clk_get_rate(&i2c_bus->per_clk); if (clock_rate <= 0) { dev_err(bus, "Failed to get i2c clk: %d\n", clock_rate); @@ -462,7 +462,7 @@ static int imx_lpi2c_probe(struct udevice *bus) return ret; } - if (IS_ENABLED(CONFIG_CLK)) { + if (CONFIG_IS_ENABLED(CLK)) { ret = clk_get_by_name(bus, "per", &i2c_bus->per_clk); if (ret) { dev_err(bus, "Failed to get per clk\n");