| Message ID | 20230329112246.136251-6-marcel@ziswiler.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | board: verdin-imx8mp: ddr updates | expand |
Hi Marcel, The whole series looks good. On Wed, Mar 29, 2023 at 8:24 AM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > change prints to show which DDR configuration (single/dual rank) is used > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > board/toradex/verdin-imx8mp/spl.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/board/toradex/verdin-imx8mp/spl.c b/board/toradex/verdin-imx8mp/spl.c > index ab5bcbc0929..f43c6cc02f8 100644 > --- a/board/toradex/verdin-imx8mp/spl.c > +++ b/board/toradex/verdin-imx8mp/spl.c > @@ -35,11 +35,17 @@ void spl_dram_init(void) > /* > * Try configuring for dual rank memory falling back to single rank > */ > - if (ddr_init(&dram_timing)) { > - printf("Dual rank failed, attempting single rank configuration.\n"); > - lpddr4_single_rank_training_patch(); > - ddr_init(&dram_timing); > + if (!ddr_init(&dram_timing)) { > + printf("DDR configured as dual rank\n"); Just a minor suggestion: puts() can be used instead of printf() as it uses less resources and can help inside a memory constrained environment, such as SPL.
diff --git a/board/toradex/verdin-imx8mp/spl.c b/board/toradex/verdin-imx8mp/spl.c index ab5bcbc0929..f43c6cc02f8 100644 --- a/board/toradex/verdin-imx8mp/spl.c +++ b/board/toradex/verdin-imx8mp/spl.c @@ -35,11 +35,17 @@ void spl_dram_init(void) /* * Try configuring for dual rank memory falling back to single rank */ - if (ddr_init(&dram_timing)) { - printf("Dual rank failed, attempting single rank configuration.\n"); - lpddr4_single_rank_training_patch(); - ddr_init(&dram_timing); + if (!ddr_init(&dram_timing)) { + printf("DDR configured as dual rank\n"); + return; } + + lpddr4_single_rank_training_patch(); + if (!ddr_init(&dram_timing)) { + printf("DDR configured as single rank\n"); + return; + } + printf("DDR configuration failed\n"); } void spl_board_init(void)