diff mbox series

arm: kirkwood: Enable Debug UART for Zyxel NSA310S

Message ID 20230313033552.31721-1-mibodhi@gmail.com
State Accepted
Commit 003c3585e2741ca6fc2e49d74cb20ba8d742c590
Delegated to: Stefan Roese
Headers show
Series arm: kirkwood: Enable Debug UART for Zyxel NSA310S | expand

Commit Message

Tony Dinh March 13, 2023, 3:35 a.m. UTC
It's useful to enable Debug UART for future DM Serial regression tests
for Kirkwood boards.

Also, see background discussion in this thread:
https://lists.denx.de/pipermail/u-boot/2023-March/512010.html

Signed-off-by: Tony Dinh <mibodhi@gmail.com>
---

 configs/nsa310s_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Pali Rohár March 14, 2023, 8:17 a.m. UTC | #1
On Sunday 12 March 2023 20:35:51 Tony Dinh wrote:
> It's useful to enable Debug UART for future DM Serial regression tests
> for Kirkwood boards.
> 
> Also, see background discussion in this thread:
> https://lists.denx.de/pipermail/u-boot/2023-March/512010.html
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
> 
>  configs/nsa310s_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig
> index 76839e62dd..b936ae1b25 100644
> --- a/configs/nsa310s_defconfig
> +++ b/configs/nsa310s_defconfig
> @@ -15,8 +15,11 @@ CONFIG_ENV_SIZE=0x20000
>  CONFIG_ENV_OFFSET=0xE0000
>  CONFIG_DEFAULT_DEVICE_TREE="kirkwood-nsa310s"
>  CONFIG_SYS_PROMPT="NSA310s> "
> +CONFIG_DEBUG_UART_BASE=0xf1012000
> +CONFIG_DEBUG_UART_CLOCK=166666667
>  CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server"
>  CONFIG_SYS_LOAD_ADDR=0x800000
> +CONFIG_DEBUG_UART=y
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=3
>  CONFIG_USE_PREBOOT=y
> @@ -50,6 +53,7 @@ CONFIG_MTD_RAW_NAND=y
>  CONFIG_PHY_MARVELL=y
>  CONFIG_MVGBE=y
>  CONFIG_MII=y
> +CONFIG_DEBUG_UART_SHIFT=2
>  CONFIG_USB=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_UBIFS_SILENCE_MSG=y
> -- 
> 2.30.2
>
Stefan Roese March 16, 2023, 9:02 a.m. UTC | #2
On 3/13/23 04:35, Tony Dinh wrote:
> It's useful to enable Debug UART for future DM Serial regression tests
> for Kirkwood boards.
> 
> Also, see background discussion in this thread:
> https://lists.denx.de/pipermail/u-boot/2023-March/512010.html
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> 
>   configs/nsa310s_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig
> index 76839e62dd..b936ae1b25 100644
> --- a/configs/nsa310s_defconfig
> +++ b/configs/nsa310s_defconfig
> @@ -15,8 +15,11 @@ CONFIG_ENV_SIZE=0x20000
>   CONFIG_ENV_OFFSET=0xE0000
>   CONFIG_DEFAULT_DEVICE_TREE="kirkwood-nsa310s"
>   CONFIG_SYS_PROMPT="NSA310s> "
> +CONFIG_DEBUG_UART_BASE=0xf1012000
> +CONFIG_DEBUG_UART_CLOCK=166666667
>   CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server"
>   CONFIG_SYS_LOAD_ADDR=0x800000
> +CONFIG_DEBUG_UART=y
>   CONFIG_DISTRO_DEFAULTS=y
>   CONFIG_BOOTDELAY=3
>   CONFIG_USE_PREBOOT=y
> @@ -50,6 +53,7 @@ CONFIG_MTD_RAW_NAND=y
>   CONFIG_PHY_MARVELL=y
>   CONFIG_MVGBE=y
>   CONFIG_MII=y
> +CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_USB=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_UBIFS_SILENCE_MSG=y

Viele Grüße,
Stefan Roese
Stefan Roese March 24, 2023, 2:42 p.m. UTC | #3
On 3/13/23 04:35, Tony Dinh wrote:
> It's useful to enable Debug UART for future DM Serial regression tests
> for Kirkwood boards.
> 
> Also, see background discussion in this thread:
> https://lists.denx.de/pipermail/u-boot/2023-March/512010.html
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>

Applied to u-boot-marvell/next

Thanks,
Stefan

> ---
> 
>   configs/nsa310s_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig
> index 76839e62dd..b936ae1b25 100644
> --- a/configs/nsa310s_defconfig
> +++ b/configs/nsa310s_defconfig
> @@ -15,8 +15,11 @@ CONFIG_ENV_SIZE=0x20000
>   CONFIG_ENV_OFFSET=0xE0000
>   CONFIG_DEFAULT_DEVICE_TREE="kirkwood-nsa310s"
>   CONFIG_SYS_PROMPT="NSA310s> "
> +CONFIG_DEBUG_UART_BASE=0xf1012000
> +CONFIG_DEBUG_UART_CLOCK=166666667
>   CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server"
>   CONFIG_SYS_LOAD_ADDR=0x800000
> +CONFIG_DEBUG_UART=y
>   CONFIG_DISTRO_DEFAULTS=y
>   CONFIG_BOOTDELAY=3
>   CONFIG_USE_PREBOOT=y
> @@ -50,6 +53,7 @@ CONFIG_MTD_RAW_NAND=y
>   CONFIG_PHY_MARVELL=y
>   CONFIG_MVGBE=y
>   CONFIG_MII=y
> +CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_USB=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_UBIFS_SILENCE_MSG=y

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig
index 76839e62dd..b936ae1b25 100644
--- a/configs/nsa310s_defconfig
+++ b/configs/nsa310s_defconfig
@@ -15,8 +15,11 @@  CONFIG_ENV_SIZE=0x20000
 CONFIG_ENV_OFFSET=0xE0000
 CONFIG_DEFAULT_DEVICE_TREE="kirkwood-nsa310s"
 CONFIG_SYS_PROMPT="NSA310s> "
+CONFIG_DEBUG_UART_BASE=0xf1012000
+CONFIG_DEBUG_UART_CLOCK=166666667
 CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server"
 CONFIG_SYS_LOAD_ADDR=0x800000
+CONFIG_DEBUG_UART=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=3
 CONFIG_USE_PREBOOT=y
@@ -50,6 +53,7 @@  CONFIG_MTD_RAW_NAND=y
 CONFIG_PHY_MARVELL=y
 CONFIG_MVGBE=y
 CONFIG_MII=y
+CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_UBIFS_SILENCE_MSG=y