diff mbox series

ARM: dts: imx: Add WDT bindings on DH i.MX6 DHSOM

Message ID 20230305204908.772661-1-marex@denx.de
State Changes Requested
Delegated to: Stefano Babic
Headers show
Series ARM: dts: imx: Add WDT bindings on DH i.MX6 DHSOM | expand

Commit Message

Marek Vasut March 5, 2023, 8:49 p.m. UTC
Add WDT reboot bindings on DH i.MX6 DHSOM to permit the platform
to reboot via WDT in U-Boot. These are custom U-Boot bindings,
hence they are placed in -u-boot.dtsi .

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andreas Geisreiter <ageisreiter@dh-electronics.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: u-boot@dh-electronics.com
---
 arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Fabio Estevam March 6, 2023, 12:40 p.m. UTC | #1
On 05/03/2023 17:49, Marek Vasut wrote:
> Add WDT reboot bindings on DH i.MX6 DHSOM to permit the platform
> to reboot via WDT in U-Boot. These are custom U-Boot bindings,
> hence they are placed in -u-boot.dtsi .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Fabio Estevam <festevam@denx.de>
Stefano Babic March 30, 2023, 3:28 p.m. UTC | #2
Hi Marek,

On 05.03.23 21:49, Marek Vasut wrote:
> Add WDT reboot bindings on DH i.MX6 DHSOM to permit the platform
> to reboot via WDT in U-Boot. These are custom U-Boot bindings,
> hence they are placed in -u-boot.dtsi .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andreas Geisreiter <ageisreiter@dh-electronics.de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: u-boot@dh-electronics.com
> ---
>   arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi b/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
> index 190567ab7ba..06ad98bccf6 100644
> --- a/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
> +++ b/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
> @@ -8,6 +8,12 @@
>   	aliases {
>   		eeprom0 = &eeprom0;
>   	};
> +
> +	wdt-reboot {
> +		compatible = "wdt-reboot";
> +		wdt = <&wdog1>;
> +		u-boot,dm-spl;
> +	}

I cannot merge it, u-boot,dm-spl is not allowed anymore (see 
https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/604593), 
switched to bootph-pre-ram ?

Same is for the other patch of yours:

http://patchwork.ozlabs.org/project/uboot/patch/20230208113347.131572-1-marex@denx.de/


Best regards,
Stefano
;
>   };
>   
>   &fec {
> @@ -25,3 +31,7 @@
>   	gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>;
>   	enable-active-high;
>   };
> +
> +&wdog1 {
> +	u-boot,dm-spl;
> +};
diff mbox series

Patch

diff --git a/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi b/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
index 190567ab7ba..06ad98bccf6 100644
--- a/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
+++ b/arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi
@@ -8,6 +8,12 @@ 
 	aliases {
 		eeprom0 = &eeprom0;
 	};
+
+	wdt-reboot {
+		compatible = "wdt-reboot";
+		wdt = <&wdog1>;
+		u-boot,dm-spl;
+	};
 };
 
 &fec {
@@ -25,3 +31,7 @@ 
 	gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>;
 	enable-active-high;
 };
+
+&wdog1 {
+	u-boot,dm-spl;
+};