Message ID | 20230210122352.1214847-1-sr@denx.de |
---|---|
State | Accepted |
Commit | 46beaec835d9828ceaafe070401cb4efb80b4fe3 |
Delegated to: | Jaehoon Chung |
Headers | show |
Series | [1/3] mmc: mv_sdhci: Simplify call to sdhci_mvebu_mbus_config() | expand |
On 2/10/23 21:23, Stefan Roese wrote: > This driver already depends on CONFIG_ARCH_MVEBU, so there is no need > to have some checks for this Kconfig symbol in the driver itself. Let's > remove these superfluous checks. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tom Rini <trini@konsulko.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/mv_sdhci.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c > index 336ebf141026..50d03b703ed7 100644 > --- a/drivers/mmc/mv_sdhci.c > +++ b/drivers/mmc/mv_sdhci.c > @@ -64,10 +64,8 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks) > host->ops = &mv_ops; > #endif > > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > - /* Configure SDHCI MBUS mbus bridge windows */ > - sdhci_mvebu_mbus_config((void __iomem *)regbase); > - } > + /* Configure SDHCI MBUS mbus bridge windows */ > + sdhci_mvebu_mbus_config((void __iomem *)regbase); > > return add_sdhci(host, 0, min_clk); > } > @@ -103,10 +101,8 @@ static int mv_sdhci_probe(struct udevice *dev) > if (ret) > return ret; > > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > - /* Configure SDHCI MBUS mbus bridge windows */ > - sdhci_mvebu_mbus_config(host->ioaddr); > - } > + /* Configure SDHCI MBUS mbus bridge windows */ > + sdhci_mvebu_mbus_config(host->ioaddr); > > upriv->mmc = host->mmc; >
On 2/10/23 21:23, Stefan Roese wrote: > This driver already depends on CONFIG_ARCH_MVEBU, so there is no need > to have some checks for this Kconfig symbol in the driver itself. Let's > remove these superfluous checks. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tom Rini <trini@konsulko.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot-mmc/master. Best Regards, Jaehoon Chung > --- > drivers/mmc/mv_sdhci.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c > index 336ebf141026..50d03b703ed7 100644 > --- a/drivers/mmc/mv_sdhci.c > +++ b/drivers/mmc/mv_sdhci.c > @@ -64,10 +64,8 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks) > host->ops = &mv_ops; > #endif > > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > - /* Configure SDHCI MBUS mbus bridge windows */ > - sdhci_mvebu_mbus_config((void __iomem *)regbase); > - } > + /* Configure SDHCI MBUS mbus bridge windows */ > + sdhci_mvebu_mbus_config((void __iomem *)regbase); > > return add_sdhci(host, 0, min_clk); > } > @@ -103,10 +101,8 @@ static int mv_sdhci_probe(struct udevice *dev) > if (ret) > return ret; > > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > - /* Configure SDHCI MBUS mbus bridge windows */ > - sdhci_mvebu_mbus_config(host->ioaddr); > - } > + /* Configure SDHCI MBUS mbus bridge windows */ > + sdhci_mvebu_mbus_config(host->ioaddr); > > upriv->mmc = host->mmc; >
diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c index 336ebf141026..50d03b703ed7 100644 --- a/drivers/mmc/mv_sdhci.c +++ b/drivers/mmc/mv_sdhci.c @@ -64,10 +64,8 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks) host->ops = &mv_ops; #endif - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { - /* Configure SDHCI MBUS mbus bridge windows */ - sdhci_mvebu_mbus_config((void __iomem *)regbase); - } + /* Configure SDHCI MBUS mbus bridge windows */ + sdhci_mvebu_mbus_config((void __iomem *)regbase); return add_sdhci(host, 0, min_clk); } @@ -103,10 +101,8 @@ static int mv_sdhci_probe(struct udevice *dev) if (ret) return ret; - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { - /* Configure SDHCI MBUS mbus bridge windows */ - sdhci_mvebu_mbus_config(host->ioaddr); - } + /* Configure SDHCI MBUS mbus bridge windows */ + sdhci_mvebu_mbus_config(host->ioaddr); upriv->mmc = host->mmc;
This driver already depends on CONFIG_ARCH_MVEBU, so there is no need to have some checks for this Kconfig symbol in the driver itself. Let's remove these superfluous checks. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Tom Rini <trini@konsulko.com> Cc: Simon Glass <sjg@chromium.org> Cc: Peng Fan <peng.fan@nxp.com> Cc: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/mv_sdhci.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)