diff mbox series

[v4,1/5] asm/arch-meson: add missing meson_sm_write_efuse signature

Message ID 20230110105650.54580-2-avromanov@sberdevices.ru
State Accepted
Commit 12d782734927818b9d2f197e3905410632b01fcc
Delegated to: Neil Armstrong
Headers show
Series arch-meson: introduce efusedump command | expand

Commit Message

Alexey Romanov Jan. 10, 2023, 10:56 a.m. UTC
This function can be used by other modules. Also add comments.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm/include/asm/arch-meson/sm.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

Mattijs Korpershoek Jan. 10, 2023, 1:40 p.m. UTC | #1
On Tue, Jan 10, 2023 at 13:56, Alexey Romanov <avromanov@sberdevices.ru> wrote:

> This function can be used by other modules. Also add comments.
>
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  arch/arm/include/asm/arch-meson/sm.h | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h
> index f3ae46a6d6b..53b75176493 100644
> --- a/arch/arm/include/asm/arch-meson/sm.h
> +++ b/arch/arm/include/asm/arch-meson/sm.h
> @@ -6,10 +6,35 @@
>  #ifndef __MESON_SM_H__
>  #define __MESON_SM_H__
>  
> +/**
> + * meson_sm_read_efuse - read efuse memory into buffer
> + *
> + * @offset: offset from the start efuse memory
> + * @buffer: pointer to buffer
> + * @size: number of bytes to read
> + * @return: number of bytes read
> + */
>  ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size);
>  
> +/**
> + * meson_sm_write_efuse - write into efuse memory from buffer
> + *
> + * @offset: offset from the start efuse memory
> + * @buffer: pointer to buffer
> + * @size: number of bytes to write
> + * @return: number of bytes written
> + */
> +ssize_t meson_sm_write_efuse(uintptr_t offset, void *buffer, size_t size);
> +
>  #define SM_SERIAL_SIZE	12
>  
> +/**
> + * meson_sm_get_serial - read chip unique id into buffer
> + *
> + * @buffer: pointer to buffer
> + * @size: buffer size.
> + * @return: zero on success or -errno on failure
> + */
>  int meson_sm_get_serial(void *buffer, size_t size);
>  
>  enum {
> @@ -28,6 +53,9 @@ enum {
>  	REBOOT_REASON_WATCHDOG_REBOOT = 13,
>  };
>  
> +/**
> + * meson_sm_get_reboot_reason - get reboot reason
> + */
>  int meson_sm_get_reboot_reason(void);
>  
>  #endif /* __MESON_SM_H__ */
> -- 
> 2.25.1
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h
index f3ae46a6d6b..53b75176493 100644
--- a/arch/arm/include/asm/arch-meson/sm.h
+++ b/arch/arm/include/asm/arch-meson/sm.h
@@ -6,10 +6,35 @@ 
 #ifndef __MESON_SM_H__
 #define __MESON_SM_H__
 
+/**
+ * meson_sm_read_efuse - read efuse memory into buffer
+ *
+ * @offset: offset from the start efuse memory
+ * @buffer: pointer to buffer
+ * @size: number of bytes to read
+ * @return: number of bytes read
+ */
 ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size);
 
+/**
+ * meson_sm_write_efuse - write into efuse memory from buffer
+ *
+ * @offset: offset from the start efuse memory
+ * @buffer: pointer to buffer
+ * @size: number of bytes to write
+ * @return: number of bytes written
+ */
+ssize_t meson_sm_write_efuse(uintptr_t offset, void *buffer, size_t size);
+
 #define SM_SERIAL_SIZE	12
 
+/**
+ * meson_sm_get_serial - read chip unique id into buffer
+ *
+ * @buffer: pointer to buffer
+ * @size: buffer size.
+ * @return: zero on success or -errno on failure
+ */
 int meson_sm_get_serial(void *buffer, size_t size);
 
 enum {
@@ -28,6 +53,9 @@  enum {
 	REBOOT_REASON_WATCHDOG_REBOOT = 13,
 };
 
+/**
+ * meson_sm_get_reboot_reason - get reboot reason
+ */
 int meson_sm_get_reboot_reason(void);
 
 #endif /* __MESON_SM_H__ */