| Message ID | 20230104020743.30046-1-rick@andestech.com |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | [v3] riscv: ae350: support openSBI 1.0+ which enable FW_PIC | expand |
On Wed, Jan 4, 2023 at 10:08 AM Rick Chen <rick@andestech.com> wrote: > > Original openSBI (without FW_PIC) will relocate itself nits: OpenSBI > from 0x1000000 to 0x0. After openSBI added FW_PIC codes, ditto > it will not relocate any more and always run at 0x1000000. > Hence, it may overlap with Kernel memory region. So it is with the Linux kernel? > necessary to change openSBI address from 0x1000000 to 0x0. ditto > > More details can refer to commit cb052d771200 > ("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+") > > Signed-off-by: Rick Chen <rick@andestech.com> > Reviewed-by: Samuel Holland <samuel@sholland.org> > --- > Changes in v3 > - fix typos > --- > board/AndesTech/ax25-ae350/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig > index 36b67f0b52..4bb33b0793 100644 > --- a/board/AndesTech/ax25-ae350/Kconfig > +++ b/board/AndesTech/ax25-ae350/Kconfig > @@ -25,7 +25,7 @@ config SPL_TEXT_BASE > default 0x800000 > > config SPL_OPENSBI_LOAD_ADDR > - default 0x01000000 > + default 0x00000000 > > config SYS_FDT_BASE > hex > -- > 2.17.1 > Otherwise, Reviewed-by: Bin Meng <bmeng@tinylab.org>
> On Wed, Jan 4, 2023 at 10:08 AM Rick Chen <rick@andestech.com> wrote: > > > > Original openSBI (without FW_PIC) will relocate itself > > nits: OpenSBI > > > from 0x1000000 to 0x0. After openSBI added FW_PIC codes, > > ditto OK, will fix it. > > > it will not relocate any more and always run at 0x1000000. > > Hence, it may overlap with Kernel memory region. So it is > > with the Linux kernel? > > > necessary to change openSBI address from 0x1000000 to 0x0. > > ditto OK, will fix it. > > > > > More details can refer to commit cb052d771200 > > ("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+") > > > > Signed-off-by: Rick Chen <rick@andestech.com> > > Reviewed-by: Samuel Holland <samuel@sholland.org> > > --- > > Changes in v3 > > - fix typos > > --- > > board/AndesTech/ax25-ae350/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig > > index 36b67f0b52..4bb33b0793 100644 > > --- a/board/AndesTech/ax25-ae350/Kconfig > > +++ b/board/AndesTech/ax25-ae350/Kconfig > > @@ -25,7 +25,7 @@ config SPL_TEXT_BASE > > default 0x800000 > > > > config SPL_OPENSBI_LOAD_ADDR > > - default 0x01000000 > > + default 0x00000000 > > > > config SYS_FDT_BASE > > hex > > -- > > 2.17.1 > > > > Otherwise, > Reviewed-by: Bin Meng <bmeng@tinylab.org> Thanks for reviewing. B.R, Rick
diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig index 36b67f0b52..4bb33b0793 100644 --- a/board/AndesTech/ax25-ae350/Kconfig +++ b/board/AndesTech/ax25-ae350/Kconfig @@ -25,7 +25,7 @@ config SPL_TEXT_BASE default 0x800000 config SPL_OPENSBI_LOAD_ADDR - default 0x01000000 + default 0x00000000 config SYS_FDT_BASE hex
Original openSBI (without FW_PIC) will relocate itself from 0x1000000 to 0x0. After openSBI added FW_PIC codes, it will not relocate any more and always run at 0x1000000. Hence, it may overlap with Kernel memory region. So it is necessary to change openSBI address from 0x1000000 to 0x0. More details can refer to commit cb052d771200 ("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+") Signed-off-by: Rick Chen <rick@andestech.com> Reviewed-by: Samuel Holland <samuel@sholland.org> --- Changes in v3 - fix typos --- board/AndesTech/ax25-ae350/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)