| Message ID | 20221215145117.427066-1-arnaud.ferraris@collabora.com |
|---|---|
| State | Accepted |
| Commit | a437d14fc8b2d935c9071082cd3e820d5d033251 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | imx8mq_pins: fix configuration for UART4 on ECSPI2 pads | expand |
On Thu, Dec 15, 2022 at 11:51 AM Arnaud Ferraris <arnaud.ferraris@collabora.com> wrote: > diff --git a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h > index c71913f209..16d418c687 100644 > --- a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h > +++ b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h > @@ -538,7 +538,7 @@ enum { > IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10 = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0), > > IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0), > - IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0), > + IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0), Yes, the DT definition does the same: #define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DCE_TX 0x208 0x470 0x000 0x1 0x0 #define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DTE_RX 0x208 0x470 0x50C 0x1 0x1 Reviewed-by: Fabio Estevam <festevam@denx.de>
> When routing UART4 using the ECSPI2 pads, register > IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only > when dealing with RX, as its name suggests. > Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> > Reviewed-by: Fabio Estevam <festevam@denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h index c71913f209..16d418c687 100644 --- a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h +++ b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h @@ -538,7 +538,7 @@ enum { IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10 = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0), IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0), - IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0), + IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0), IMX8MQ_PAD_ECSPI2_MOSI__GPIO5_IO11 = IOMUX_PAD(0x0470, 0x0208, 5, 0x0000, 0, 0), IMX8MQ_PAD_ECSPI2_MISO__ECSPI2_MISO = IOMUX_PAD(0x0474, 0x020C, 0, 0x0000, 0, 0),
When routing UART4 using the ECSPI2 pads, register IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only when dealing with RX, as its name suggests. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> --- arch/arm/include/asm/arch-imx8m/imx8mq_pins.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)