| Message ID | 20221202045348.1634-2-liangshenlin@eswincomputing.com |
|---|---|
| State | Accepted |
| Commit | c9c42ad21fe4fe7bdd39e8557ac15aad92b5d968 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | common:autoboot:modify function parameters | expand |
On Sat, 3 Dec 2022 at 01:25, Shenlin Liang <liangshenlin@eswincomputing.com> wrote: > > the blob parameter of the function process_fdt_options has not been > invoked in the function body and should be changed to void type > > Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com> > --- > common/autoboot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, Dec 02, 2022 at 12:53:48PM +0800, Shenlin Liang wrote: > the blob parameter of the function process_fdt_options has not been > invoked in the function body and should be changed to void type > > Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/common/autoboot.c b/common/autoboot.c index ea44fdf6ad..848c33b2f2 100644 --- a/common/autoboot.c +++ b/common/autoboot.c @@ -422,7 +422,7 @@ static int abortboot(int bootdelay) return abort; } -static void process_fdt_options(const void *blob) +static void process_fdt_options(void) { #ifdef CONFIG_TEXT_BASE ulong addr; @@ -474,7 +474,7 @@ const char *bootdelay_process(void) s = env_get("bootcmd"); if (IS_ENABLED(CONFIG_OF_CONTROL)) - process_fdt_options(gd->fdt_blob); + process_fdt_options(); stored_bootdelay = bootdelay; return s;
the blob parameter of the function process_fdt_options has not been invoked in the function body and should be changed to void type Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com> --- common/autoboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)