From patchwork Wed Nov 23 07:17:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahisa Kojima X-Patchwork-Id: 1708159 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SjrMO6Vm; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NHCBP37rkz23np for ; Wed, 23 Nov 2022 18:17:33 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E42A385554; Wed, 23 Nov 2022 08:17:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SjrMO6Vm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 552A48554C; Wed, 23 Nov 2022 08:17:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1348B85411 for ; Wed, 23 Nov 2022 08:17:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=masahisa.kojima@linaro.org Received: by mail-pf1-x42e.google.com with SMTP id w129so188764pfb.5 for ; Tue, 22 Nov 2022 23:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=pA2BxIpOl7nuMZWQDxJYWhL5Bx/DlhTtOWIOJcB0eyM=; b=SjrMO6VmWMTjQcduLIrvPSM+I2YO5s4qI5FyGMdpdJPHXQTp8CSeMKjNvmIxBW2UKk gXQqepSBVMOVFO8PNMKGgNrGQ/GK/5vpr2XFFlGrtzIXd+lLX/9j7Jp5jAP53J0hWUAi QxLQmAuNRMYX9jB/2PA5TV57EZyXQAb5lObNatRA4Oau3GtQDsimU5tARt46LFl60ODD MX2Q/toLS0Rqi82BsPT/+VCyDm6YrbdpFGNAlrfiMHegWxvudM3kC65zdD3SEUVh20lp 4qFkXrS3ogCZ1fi3Pe3ilfVptMKG//O9w7VSiVX+RJ1neQNjobOSiK3DmgYPilf5yWGv IVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pA2BxIpOl7nuMZWQDxJYWhL5Bx/DlhTtOWIOJcB0eyM=; b=ZtQNJZ31TXSX7Br9IRFxU1rLNLqHXFIKxvGMmwK4ags8KqODQ/jsJhVM9+ME1mdg45 5Q5eMTW1plocyTUzp71iGBuY0pMHlE46aCd+8SWpbuCOHSybDveS+8Ukcj1sfW0ejFbY C6qxRvfnPD8obTqhjs88Ez+EiR81tJdWHZm83160FSS4UgxDU+7ZLx+6Cy0alSKDwl2j MuAOqu0deLSpg4piseMiImooymgeyseXc0Ak5pIOHc/fzN3W4xVePXa4y96dKi3GVoNG RZENSAUZZmz0PvEtFO3EmUk87yGmytx6LYn18bhSMgwTBkpDVGaBExme++2V/GrLfZ1a L1YQ== X-Gm-Message-State: ANoB5pld6v7wXm91EyS4csv+SGVzfF7NWUPRTdIAdubKrSl9NbqGQO0Y zG8G2jKJ/Zixnvx5qG7XoiHgmGD3bhVwCQ== X-Google-Smtp-Source: AA0mqf7fS4X7LEvzdYVnMdRLP3cbcaByTZTtXX7yN1nUnj3auWC4xgiXbt38l6FkiVyMDl9eZY9aRA== X-Received: by 2002:a63:e4a:0:b0:477:6cd0:9a04 with SMTP id 10-20020a630e4a000000b004776cd09a04mr12371803pgo.433.1669187834084; Tue, 22 Nov 2022 23:17:14 -0800 (PST) Received: from localhost.localdomain ([240d:1a:cf7:5800:82fa:5bff:fe4b:26b1]) by smtp.gmail.com with ESMTPSA id n20-20020a170902d0d400b0016d72804664sm5512863pln.205.2022.11.22.23.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 23:17:13 -0800 (PST) From: Masahisa Kojima To: u-boot@lists.denx.de Cc: Heinrich Schuchardt , Ilias Apalodimas , Masahisa Kojima Subject: [PATCH 1/3] eficonfig: fix going one directory up issue Date: Wed, 23 Nov 2022 16:17:08 +0900 Message-Id: <20221123071710.28506-2-masahisa.kojima@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221123071710.28506-1-masahisa.kojima@linaro.org> References: <20221123071710.28506-1-masahisa.kojima@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The directory name in eficonfig menu entry contains the '\' separator. strcmp() argument ".." is wrong and one directory up handling does not work correctly. strcmp() argument must include '\' separator. Signed-off-by: Masahisa Kojima --- cmd/eficonfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 97d35597a2..5529edc85e 100644 --- a/cmd/eficonfig.c +++ b/cmd/eficonfig.c @@ -488,7 +488,7 @@ static efi_status_t eficonfig_file_selected(void *data) if (!info) return EFI_INVALID_PARAMETER; - if (!strcmp(info->file_name, "..")) { + if (!strcmp(info->file_name, "..\\")) { struct eficonfig_filepath_info *iter; struct list_head *pos, *n; int is_last;