| Message ID | 20221013084121.430492-1-jh80.chung@samsung.com |
|---|---|
| State | Accepted |
| Commit | c059a22b7776dc4306acb73cbeb78e841cf60b84 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | tools: env: fw_env: Fix unused-result warning | expand |
On Thu, Oct 13, 2022 at 05:41:21PM +0900, Jaehoon Chung wrote: > Fix unused-result warning about fread. > > tools/env/fw_env.c: In function ‘find_nvmem_device’: > tools/env/fw_env.c:1751:3: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] > 1751 | fread(buf, sizeof(buf), 1, fp); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot/next, thanks!
diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index c251e2e6ba7d..c9a8774acefb 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -1733,6 +1733,7 @@ static int find_nvmem_device(void) while (!nvmem && (dent = readdir(dir))) { FILE *fp; + size_t size; if (!strcmp(dent->d_name, ".") || !strcmp(dent->d_name, "..")) { continue; @@ -1748,7 +1749,14 @@ static int find_nvmem_device(void) continue; } - fread(buf, sizeof(buf), 1, fp); + size = fread(buf, sizeof(buf), 1, fp); + if (size != 1) { + fprintf(stderr, + "read failed about %s\n", comp); + fclose(fp); + return -EIO; + } + if (!strcmp(buf, "u-boot,env")) { bytes = asprintf(&nvmem, "%s/%s/nvmem", path, dent->d_name);
Fix unused-result warning about fread. tools/env/fw_env.c: In function ‘find_nvmem_device’: tools/env/fw_env.c:1751:3: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] 1751 | fread(buf, sizeof(buf), 1, fp); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- tools/env/fw_env.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)