diff mbox series

[u-boot,07/14] mtd: rawnand: nand_spl_loaders: Fix cast type build warning

Message ID 20221011115012.6181-8-rogerq@kernel.org
State Accepted, archived
Commit 664d5369269f80d0883ede4573425e3546c87080
Delegated to: Dario Binacchi
Headers show
Series rawnand: omap_gpmc: driver model support | expand

Commit Message

Roger Quadros Oct. 11, 2022, 11:50 a.m. UTC
Fixes the below build warning on 64-bit platforms.

drivers/mtd/nand/raw/nand_spl_loaders.c:26:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      dst = (void *)((int)dst - page_offset);

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/mtd/nand/raw/nand_spl_loaders.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Trimarchi Nov. 6, 2022, 7:50 p.m. UTC | #1
On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros <rogerq@kernel.org> wrote:
>
> Fixes the below build warning on 64-bit platforms.
>
> drivers/mtd/nand/raw/nand_spl_loaders.c:26:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>       dst = (void *)((int)dst - page_offset);
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  drivers/mtd/nand/raw/nand_spl_loaders.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_spl_loaders.c b/drivers/mtd/nand/raw/nand_spl_loaders.c
> index 4befc75c04..156b44d835 100644
> --- a/drivers/mtd/nand/raw/nand_spl_loaders.c
> +++ b/drivers/mtd/nand/raw/nand_spl_loaders.c
> @@ -23,7 +23,7 @@ int nand_spl_load_image(uint32_t offs, unsigned int size, void *dst)
>                                 if (unlikely(page_offset)) {
>                                         memmove(dst, dst + page_offset,
>                                                 CONFIG_SYS_NAND_PAGE_SIZE);
> -                                       dst = (void *)((int)dst - page_offset);
> +                                       dst = (void *)(dst - page_offset);
>                                         page_offset = 0;
>                                 }
>                                 dst += CONFIG_SYS_NAND_PAGE_SIZE;

Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/nand_spl_loaders.c b/drivers/mtd/nand/raw/nand_spl_loaders.c
index 4befc75c04..156b44d835 100644
--- a/drivers/mtd/nand/raw/nand_spl_loaders.c
+++ b/drivers/mtd/nand/raw/nand_spl_loaders.c
@@ -23,7 +23,7 @@  int nand_spl_load_image(uint32_t offs, unsigned int size, void *dst)
 				if (unlikely(page_offset)) {
 					memmove(dst, dst + page_offset,
 						CONFIG_SYS_NAND_PAGE_SIZE);
-					dst = (void *)((int)dst - page_offset);
+					dst = (void *)(dst - page_offset);
 					page_offset = 0;
 				}
 				dst += CONFIG_SYS_NAND_PAGE_SIZE;