diff mbox series

[v2,2/3] cmd/sbi: error message for failure to get spec version

Message ID 20221004080954.17884-3-heinrich.schuchardt@canonical.com
State Accepted
Delegated to: Andes
Headers show
Series sbi/cmd: improve output formatting | expand

Commit Message

Heinrich Schuchardt Oct. 4, 2022, 8:09 a.m. UTC 
If calling 'Get SBI specification version' fails, write an error message
and return CMD_RET_FAILURE.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Rick Chen <rick@andestech.com>
---
v2:
	no change
---
 cmd/riscv/sbi.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
index 9bbe7d4b90..24955d2be1 100644
--- a/cmd/riscv/sbi.c
+++ b/cmd/riscv/sbi.c
@@ -56,8 +56,11 @@  static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
 	long mvendorid, marchid, mimpid;
 
 	ret = sbi_get_spec_version();
-	if (ret >= 0)
-		printf("SBI %ld.%ld", ret >> 24, ret & 0xffffff);
+	if (ret < 0) {
+		printf("No SBI 0.2+\n");
+		return CMD_RET_FAILURE;
+	}
+	printf("SBI %ld.%ld", ret >> 24, ret & 0xffffff);
 	impl_id = sbi_get_impl_id();
 	if (impl_id >= 0) {
 		for (i = 0; i < ARRAY_SIZE(implementations); ++i) {