| Message ID | 20221001073940.10018-2-heinrich.schuchardt@canonical.com |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | sbi/cmd: improve output formatting | expand |
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Sent: Saturday, October 01, 2022 3:40 PM > To: Rick Jian-Zhi Chen(陳建志) <rick@andestech.com>; Leo Yu-Chi Liang(梁育齊) <ycliang@andestech.com> > Cc: u-boot@lists.denx.de; Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Subject: [PATCH 1/3] cmd/sbi: format RustSBI version number > > The SBI command can print out the version number of the SBI implementation. > Choose the correct output format for RustSBI. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > cmd/riscv/sbi.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rick Chen <rick@andestech.com>
On 10/1/22 03:39, Heinrich Schuchardt wrote: > The SBI command can print out the version number of the SBI implementation. > Choose the correct output format for RustSBI. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > cmd/riscv/sbi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c > index 522f502435..160d7c7b30 100644 > --- a/cmd/riscv/sbi.c > +++ b/cmd/riscv/sbi.c > @@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, > vers >> 16, vers & 0xffff); > break; > case 3: /* KVM */ > ++ case 4: /* RustSBI */ Did your patch get mangled? > printf("%ld.%ld.%ld", > vers >> 16, > (vers >> 8) & 0xff,
Hi Sean, On Tue, Oct 04, 2022 at 02:23:33AM -0400, Sean Anderson wrote: > On 10/1/22 03:39, Heinrich Schuchardt wrote: > > The SBI command can print out the version number of the SBI implementation. > > Choose the correct output format for RustSBI. > > > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > > --- > > cmd/riscv/sbi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c > > index 522f502435..160d7c7b30 100644 > > --- a/cmd/riscv/sbi.c > > +++ b/cmd/riscv/sbi.c > > @@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, > > vers >> 16, vers & 0xffff); > > break; > > case 3: /* KVM */ > > ++ case 4: /* RustSBI */ > > Did your patch get mangled? Thanks for the catch. I will fix that extra '+' when merging the patches. > > > printf("%ld.%ld.%ld", > > vers >> 16, > > (vers >> 8) & 0xff, > Best regards, Leo
diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c index 522f502435..160d7c7b30 100644 --- a/cmd/riscv/sbi.c +++ b/cmd/riscv/sbi.c @@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc, vers >> 16, vers & 0xffff); break; case 3: /* KVM */ ++ case 4: /* RustSBI */ printf("%ld.%ld.%ld", vers >> 16, (vers >> 8) & 0xff,
The SBI command can print out the version number of the SBI implementation. Choose the correct output format for RustSBI. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- cmd/riscv/sbi.c | 1 + 1 file changed, 1 insertion(+)