| Message ID | 20220925134328.9405-1-msuchanek@suse.de |
|---|---|
| State | Accepted |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | power: fan53555: Fix missing newline in error message | expand |
On 9/25/2022 9:43 PM, Michal Suchanek wrote: > Avoid concatenation with following message. > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > > drivers/power/pmic/fan53555.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c > index 4d1e686d27..0d91628f57 100644 > --- a/drivers/power/pmic/fan53555.c > +++ b/drivers/power/pmic/fan53555.c > @@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg, > u8 *buff, int len) > { > if (dm_i2c_read(dev, reg, buff, len)) { > - pr_err("%s: read error for register: %#x!", dev->name, reg); > + pr_err("%s: read error for register: %#x!\n", dev->name, reg); > return -EIO; > } >
On 9/25/22 22:43, Michal Suchanek wrote: > Avoid concatenation with following message. > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > > drivers/power/pmic/fan53555.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c > index 4d1e686d27..0d91628f57 100644 > --- a/drivers/power/pmic/fan53555.c > +++ b/drivers/power/pmic/fan53555.c > @@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg, > u8 *buff, int len) > { > if (dm_i2c_read(dev, reg, buff, len)) { > - pr_err("%s: read error for register: %#x!", dev->name, reg); > + pr_err("%s: read error for register: %#x!\n", dev->name, reg); > return -EIO; > } >
diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c index 4d1e686d27..0d91628f57 100644 --- a/drivers/power/pmic/fan53555.c +++ b/drivers/power/pmic/fan53555.c @@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg, u8 *buff, int len) { if (dm_i2c_read(dev, reg, buff, len)) { - pr_err("%s: read error for register: %#x!", dev->name, reg); + pr_err("%s: read error for register: %#x!\n", dev->name, reg); return -EIO; }
Avoid concatenation with following message. Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- drivers/power/pmic/fan53555.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)