diff mbox series

[2/3] mmc: stm32_sdmmc2: protect against unsupported modes

Message ID 20220913112346.301480-2-yann.gautier@foss.st.com
State Accepted
Delegated to: Jaehoon Chung
Headers show
Series [1/3] mmc: stm32_sdmmc2: add dual data rate support | expand

Commit Message

Yann Gautier Sept. 13, 2022, 11:23 a.m. UTC
The UHS modes for SD, HS200 and HS400 modes for eMMC are not supported
by the stm32_sdmmc2 driver.
Make it clear by removing the corresponding caps after parsing the DT.

Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
---

 drivers/mmc/stm32_sdmmc2.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jaehoon Chung Oct. 7, 2022, 12:33 p.m. UTC | #1
On 9/13/22 20:23, Yann Gautier wrote:
> The UHS modes for SD, HS200 and HS400 modes for eMMC are not supported
> by the stm32_sdmmc2 driver.
> Make it clear by removing the corresponding caps after parsing the DT.
> 
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/stm32_sdmmc2.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
> index 3cfa5a66f1..e1240b0cf3 100644
> --- a/drivers/mmc/stm32_sdmmc2.c
> +++ b/drivers/mmc/stm32_sdmmc2.c
> @@ -675,6 +675,8 @@ static int stm32_sdmmc2_of_to_plat(struct udevice *dev)
>  	if (ret)
>  		return ret;
>  
> +	cfg->host_caps &= ~(UHS_CAPS | MMC_MODE_HS200 | MMC_MODE_HS400 | MMC_MODE_HS400_ES);
> +
>  	ret = clk_get_by_index(dev, 0, &plat->clk);
>  	if (ret)
>  		return ret;
diff mbox series

Patch

diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
index 3cfa5a66f1..e1240b0cf3 100644
--- a/drivers/mmc/stm32_sdmmc2.c
+++ b/drivers/mmc/stm32_sdmmc2.c
@@ -675,6 +675,8 @@  static int stm32_sdmmc2_of_to_plat(struct udevice *dev)
 	if (ret)
 		return ret;
 
+	cfg->host_caps &= ~(UHS_CAPS | MMC_MODE_HS200 | MMC_MODE_HS400 | MMC_MODE_HS400_ES);
+
 	ret = clk_get_by_index(dev, 0, &plat->clk);
 	if (ret)
 		return ret;