diff mbox series

[5/9] Nokia RX-51: Call bootm in test script only when image is valid

Message ID 20220904012906.17718-6-pali@kernel.org
State Accepted
Commit 7506965885fe5eea4945c9706377a679a2974aa7
Delegated to: Tom Rini
Headers show
Series Nokia RX-51: Small cleanups and UBI boot test case | expand

Commit Message

Pali Rohár Sept. 4, 2022, 1:29 a.m. UTC
When reading of image fails then do not call bootm. This prevents false
positive test result in case something bootable is present in memory.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 test/nokia_rx51_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Sept. 15, 2022, 9:55 p.m. UTC | #1
On Sun, Sep 04, 2022 at 03:29:02AM +0200, Pali Rohár wrote:

> When reading of image fails then do not call bootm. This prevents false
> positive test result in case something bootable is present in memory.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/test/nokia_rx51_test.sh b/test/nokia_rx51_test.sh
index abd1712fd791..d2417a98bf08 100755
--- a/test/nokia_rx51_test.sh
+++ b/test/nokia_rx51_test.sh
@@ -180,7 +180,7 @@  EOF
 
 # Generate bootmenu for OneNAND booting
 cat > bootmenu_nand << EOF
-setenv bootmenu_0 'uImage-2.6.28-omap1 from OneNAND=mtd read initfs \${kernaddr}; setenv bootargs; setenv setup_omap_atag 1; bootm \${kernaddr}';
+setenv bootmenu_0 'uImage-2.6.28-omap1 from OneNAND=setenv bootargs; setenv setup_omap_atag 1; mtd read initfs \${kernaddr} && bootm \${kernaddr}';
 setenv bootmenu_1;
 setenv bootmenu_delay 1;
 setenv bootdelay 1;