diff mbox series

[v2,23/24] efi: Drop ifname field from struct efi_disk_obj

Message ID 20220812013503.1724919-24-sjg@chromium.org
State Deferred
Delegated to: Tom Rini
Headers show
Series blk: Rationalise the block interface | expand

Commit Message

Simon Glass Aug. 12, 2022, 1:35 a.m. UTC
This is not used, so drop it.

Suggested-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2:
- Add new patch to drop ifname field from struct efi_disk_obj

 lib/efi_loader/efi_disk.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Heinrich Schuchardt Sept. 13, 2022, 4:17 p.m. UTC | #1
On 8/12/22 03:35, Simon Glass wrote:
> This is not used, so drop it.
>
> Suggested-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Add new patch to drop ifname field from struct efi_disk_obj
>
>   lib/efi_loader/efi_disk.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
> index 2e905f61840..ad543bc117e 100644
> --- a/lib/efi_loader/efi_disk.c
> +++ b/lib/efi_loader/efi_disk.c
> @@ -40,7 +40,6 @@ const efi_guid_t efi_system_partition_guid = PARTITION_SYSTEM_GUID;
>   struct efi_disk_obj {
>   	struct efi_object header;
>   	struct efi_block_io ops;
> -	const char *ifname;

This patch is obsolete since commit ab31c8a15871 (" efi_loader: disk:
remove unused field").

Best regards

Heinrich

>   	int dev_index;
>   	struct efi_block_io_media media;
>   	struct efi_device_path *dp;
> @@ -476,7 +475,6 @@ static efi_status_t efi_disk_add_dev(
>   			return ret;
>   	}
>   	diskobj->ops = block_io_disk_template;
> -	diskobj->ifname = if_typename;
>   	diskobj->dev_index = dev_index;
>
>   	/* Fill in EFI IO Media info (for read/write callbacks) */
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
index 2e905f61840..ad543bc117e 100644
--- a/lib/efi_loader/efi_disk.c
+++ b/lib/efi_loader/efi_disk.c
@@ -40,7 +40,6 @@  const efi_guid_t efi_system_partition_guid = PARTITION_SYSTEM_GUID;
 struct efi_disk_obj {
 	struct efi_object header;
 	struct efi_block_io ops;
-	const char *ifname;
 	int dev_index;
 	struct efi_block_io_media media;
 	struct efi_device_path *dp;
@@ -476,7 +475,6 @@  static efi_status_t efi_disk_add_dev(
 			return ret;
 	}
 	diskobj->ops = block_io_disk_template;
-	diskobj->ifname = if_typename;
 	diskobj->dev_index = dev_index;
 
 	/* Fill in EFI IO Media info (for read/write callbacks) */