diff mbox series

[v2] imx8*_venice_defconfig: configure default MMC env device

Message ID 20220811185332.3991733-1-tharvey@gateworks.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [v2] imx8*_venice_defconfig: configure default MMC env device | expand

Commit Message

Tim Harvey Aug. 11, 2022, 6:53 p.m. UTC
When booting from USB/SDP mmc_get_env_dev() returns
CONFIG_SYS_MMC_ENV_DEV as the MMC env device (while booting from MMC
will call board_mmc_get_env_dev() to get this). Configure
CONFIG_SYS_MMC_ENV_DEV for SDHC3 (devno=2) as all Gateworks Venice
boards use SDHC3 as eMMC so that persistent env works when booting from
USB/SDP.

Reviewed-by: Fabio Estevam <festevam@denx.de>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2:
- add Fabio's Reviewed-by tag
- fixed spelling error in commit log
---
 configs/imx8mm_venice_defconfig | 1 +
 configs/imx8mn_venice_defconfig | 1 +
 configs/imx8mp_venice_defconfig | 1 +
 3 files changed, 3 insertions(+)

Comments

Peng Fan (OSS) Aug. 12, 2022, 12:35 a.m. UTC | #1
On 8/12/2022 2:53 AM, Tim Harvey wrote:
> When booting from USB/SDP mmc_get_env_dev() returns
> CONFIG_SYS_MMC_ENV_DEV as the MMC env device (while booting from MMC
> will call board_mmc_get_env_dev() to get this). Configure
> CONFIG_SYS_MMC_ENV_DEV for SDHC3 (devno=2) as all Gateworks Venice
> boards use SDHC3 as eMMC so that persistent env works when booting from
> USB/SDP.
> 
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
> v2:
> - add Fabio's Reviewed-by tag
> - fixed spelling error in commit log
> ---
>   configs/imx8mm_venice_defconfig | 1 +
>   configs/imx8mn_venice_defconfig | 1 +
>   configs/imx8mp_venice_defconfig | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> index ac0cee9705b0..05be8e4a20b5 100644
> --- a/configs/imx8mm_venice_defconfig
> +++ b/configs/imx8mm_venice_defconfig
> @@ -75,6 +75,7 @@ CONFIG_SPL_OF_CONTROL=y
>   CONFIG_OF_LIST="imx8mm-venice imx8mm-venice-gw71xx-0x imx8mm-venice-gw72xx-0x imx8mm-venice-gw73xx-0x imx8mm-venice-gw7901 imx8mm-venice-gw7902 imx8mm-venice-gw7903"
>   CONFIG_ENV_IS_IN_MMC=y
>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> +CONFIG_SYS_MMC_ENV_DEV=2
>   CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>   CONFIG_USE_ETHPRIME=y
>   CONFIG_ETHPRIME="eth0"
> diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> index 935de023161a..09287a5ae3f1 100644
> --- a/configs/imx8mn_venice_defconfig
> +++ b/configs/imx8mn_venice_defconfig
> @@ -78,6 +78,7 @@ CONFIG_SPL_OF_CONTROL=y
>   CONFIG_OF_LIST="imx8mn-venice imx8mn-venice-gw7902"
>   CONFIG_ENV_IS_IN_MMC=y
>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> +CONFIG_SYS_MMC_ENV_DEV=2
>   CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>   CONFIG_USE_ETHPRIME=y
>   CONFIG_ETHPRIME="eth0"
> diff --git a/configs/imx8mp_venice_defconfig b/configs/imx8mp_venice_defconfig
> index 7fdde41b6da5..9013a1164e9b 100644
> --- a/configs/imx8mp_venice_defconfig
> +++ b/configs/imx8mp_venice_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SPL_OF_CONTROL=y
>   CONFIG_OF_LIST="imx8mp-venice imx8mp-venice-gw74xx"
>   CONFIG_ENV_IS_IN_MMC=y
>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> +CONFIG_SYS_MMC_ENV_DEV=2
>   CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
Stefano Babic Oct. 21, 2022, 11:40 a.m. UTC | #2
> When booting from USB/SDP mmc_get_env_dev() returns
> CONFIG_SYS_MMC_ENV_DEV as the MMC env device (while booting from MMC
> will call board_mmc_get_env_dev() to get this). Configure
> CONFIG_SYS_MMC_ENV_DEV for SDHC3 (devno=2) as all Gateworks Venice
> boards use SDHC3 as eMMC so that persistent env works when booting from
> USB/SDP.
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
index ac0cee9705b0..05be8e4a20b5 100644
--- a/configs/imx8mm_venice_defconfig
+++ b/configs/imx8mm_venice_defconfig
@@ -75,6 +75,7 @@  CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIST="imx8mm-venice imx8mm-venice-gw71xx-0x imx8mm-venice-gw72xx-0x imx8mm-venice-gw73xx-0x imx8mm-venice-gw7901 imx8mm-venice-gw7902 imx8mm-venice-gw7903"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
+CONFIG_SYS_MMC_ENV_DEV=2
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_USE_ETHPRIME=y
 CONFIG_ETHPRIME="eth0"
diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
index 935de023161a..09287a5ae3f1 100644
--- a/configs/imx8mn_venice_defconfig
+++ b/configs/imx8mn_venice_defconfig
@@ -78,6 +78,7 @@  CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIST="imx8mn-venice imx8mn-venice-gw7902"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
+CONFIG_SYS_MMC_ENV_DEV=2
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_USE_ETHPRIME=y
 CONFIG_ETHPRIME="eth0"
diff --git a/configs/imx8mp_venice_defconfig b/configs/imx8mp_venice_defconfig
index 7fdde41b6da5..9013a1164e9b 100644
--- a/configs/imx8mp_venice_defconfig
+++ b/configs/imx8mp_venice_defconfig
@@ -77,6 +77,7 @@  CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIST="imx8mp-venice imx8mp-venice-gw74xx"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
+CONFIG_SYS_MMC_ENV_DEV=2
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y