diff mbox series

[2/2] net: dwc_eth_qos: Add eqos_get_enetaddr callback for stm32

Message ID 20220802085526.272953-2-patrice.chotard@foss.st.com
State Accepted
Commit 5bd4f31fea36cf4106d6314efd33ba49efcaeded
Delegated to: Tom Rini
Headers show
Series [1/2] net: dwc_eth_qos: Add eqos_get_enetaddr callback for tegra186 | expand

Commit Message

Patrice CHOTARD Aug. 2, 2022, 8:55 a.m. UTC 
Add .eqos_get_enetaddr callback defined as eqos_null_ops() to avoid
illegal access.

Fixes: a624251461bf ("net: dwc_eth_qos: introduce eqos hook eqos_get_enetaddr")

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 drivers/net/dwc_eth_qos.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ramon Fried Aug. 6, 2022, 5:45 p.m. UTC | #1 
On Tue, Aug 2, 2022 at 11:56 AM Patrice Chotard
<patrice.chotard@foss.st.com> wrote:
>
> Add .eqos_get_enetaddr callback defined as eqos_null_ops() to avoid
> illegal access.
>
> Fixes: a624251461bf ("net: dwc_eth_qos: introduce eqos hook eqos_get_enetaddr")
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>  drivers/net/dwc_eth_qos.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 09d95e4bc3..5b2e7cba14 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -1638,6 +1638,7 @@ static struct eqos_ops eqos_stm32_ops = {
>         .eqos_calibrate_pads = eqos_null_ops,
>         .eqos_disable_calibration = eqos_null_ops,
>         .eqos_set_tx_clk_speed = eqos_null_ops,
> +       .eqos_get_enetaddr = eqos_null_ops,
>         .eqos_get_tick_clk_rate = eqos_get_tick_clk_rate_stm32
>  };
>
> --
> 2.25.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tom Rini Aug. 8, 2022, 7:08 p.m. UTC | #2 
On Tue, Aug 02, 2022 at 10:55:26AM +0200, Patrice Chotard wrote:

> Add .eqos_get_enetaddr callback defined as eqos_null_ops() to avoid
> illegal access.
> 
> Fixes: a624251461bf ("net: dwc_eth_qos: introduce eqos hook eqos_get_enetaddr")
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 09d95e4bc3..5b2e7cba14 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1638,6 +1638,7 @@  static struct eqos_ops eqos_stm32_ops = {
 	.eqos_calibrate_pads = eqos_null_ops,
 	.eqos_disable_calibration = eqos_null_ops,
 	.eqos_set_tx_clk_speed = eqos_null_ops,
+	.eqos_get_enetaddr = eqos_null_ops,
 	.eqos_get_tick_clk_rate = eqos_get_tick_clk_rate_stm32
 };