diff mbox series

[04/12] rockchip: puma-rk3399: remove unused default ENV_OFFSET for SPI flashes

Message ID 20220722160655.3904213-5-foss+uboot@0leil.net
State Superseded
Delegated to: Kever Yang
Headers show
Series Puma RK3399 migration to TPL and numerous fixes | expand

Commit Message

Quentin Schulz July 22, 2022, 4:06 p.m. UTC
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

CONFIG_ENV_OFFSET is set in the defconfig to a different value already
so this isn't used. Let's remove it as to not confuse users.

Cc: Quentin Schulz <foss+uboot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 board/theobroma-systems/puma_rk3399/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kever Yang Sept. 1, 2022, 1:04 p.m. UTC | #1
On 2022/7/23 00:06, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> CONFIG_ENV_OFFSET is set in the defconfig to a different value already
> so this isn't used. Let's remove it as to not confuse users.
>
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   board/theobroma-systems/puma_rk3399/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/board/theobroma-systems/puma_rk3399/Kconfig b/board/theobroma-systems/puma_rk3399/Kconfig
> index 21946d984d..15af55574c 100644
> --- a/board/theobroma-systems/puma_rk3399/Kconfig
> +++ b/board/theobroma-systems/puma_rk3399/Kconfig
> @@ -15,9 +15,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>   config ENV_SIZE
>   	default 0x4000
>   
> -config ENV_OFFSET
> -	default 0x3fc000 if ENV_IS_IN_SPI_FLASH
> -
>   choice
>   	prompt "Theobroma Systems RK3399-Q7 DDR Option"
>   	default TARGET_PUMA_RK3399_RAM_DDR3_1333
diff mbox series

Patch

diff --git a/board/theobroma-systems/puma_rk3399/Kconfig b/board/theobroma-systems/puma_rk3399/Kconfig
index 21946d984d..15af55574c 100644
--- a/board/theobroma-systems/puma_rk3399/Kconfig
+++ b/board/theobroma-systems/puma_rk3399/Kconfig
@@ -15,9 +15,6 @@  config BOARD_SPECIFIC_OPTIONS # dummy
 config ENV_SIZE
 	default 0x4000
 
-config ENV_OFFSET
-	default 0x3fc000 if ENV_IS_IN_SPI_FLASH
-
 choice
 	prompt "Theobroma Systems RK3399-Q7 DDR Option"
 	default TARGET_PUMA_RK3399_RAM_DDR3_1333