| Message ID | 20220613173523.250697-2-dev@pschenker.ch |
|---|---|
| State | Accepted |
| Commit | 494ef10c3bf7859e7d21d9e1d608dc0b634451c2 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/3] toradex: tdx-cfg-block: use only snprintf | expand |
On Mon, Jun 13, 2022 at 07:35:22PM +0200, Philippe Schenker wrote: > From: Philippe Schenker <philippe.schenker@toradex.com> > > With those defines the length can be reused and is in one place > extendable. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
On Mon, 2022-06-13 at 19:35 +0200, Philippe Schenker wrote: > From: Philippe Schenker <philippe.schenker@toradex.com> > > With those defines the length can be reused and is in one place > extendable. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > board/toradex/common/tdx-common.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/board/toradex/common/tdx-common.c b/board/toradex/common/tdx-common.c > index 2207818447..94e603c14f 100644 > --- a/board/toradex/common/tdx-common.c > +++ b/board/toradex/common/tdx-common.c > @@ -22,13 +22,17 @@ > > #define TORADEX_OUI 0x00142dUL > > +#define SERIAL_STR_LEN 8 > +#define MODULE_VER_STR_LEN 4 // V1.1 > +#define MODULE_REV_STR_LEN 1 // [A-Z] > + > #ifdef CONFIG_TDX_CFG_BLOCK > -static char tdx_serial_str[9]; > -static char tdx_board_rev_str[6]; > +static char tdx_serial_str[SERIAL_STR_LEN + 1]; > +static char tdx_board_rev_str[MODULE_VER_STR_LEN + MODULE_REV_STR_LEN + 1]; > > #ifdef CONFIG_TDX_CFG_BLOCK_EXTRA > -static char tdx_car_serial_str[9]; > -static char tdx_car_rev_str[6]; > +static char tdx_car_serial_str[SERIAL_STR_LEN + 1]; > +static char tdx_car_rev_str[MODULE_VER_STR_LEN + MODULE_REV_STR_LEN + 1]; > static char *tdx_carrier_board_name; > #endif
On Mon, Jun 13, 2022 at 07:35:22PM +0200, Philippe Schenker wrote: > From: Philippe Schenker <philippe.schenker@toradex.com> > > With those defines the length can be reused and is in one place > extendable. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com> > Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> Applied to u-boot/next, thanks!
diff --git a/board/toradex/common/tdx-common.c b/board/toradex/common/tdx-common.c index 2207818447..94e603c14f 100644 --- a/board/toradex/common/tdx-common.c +++ b/board/toradex/common/tdx-common.c @@ -22,13 +22,17 @@ #define TORADEX_OUI 0x00142dUL +#define SERIAL_STR_LEN 8 +#define MODULE_VER_STR_LEN 4 // V1.1 +#define MODULE_REV_STR_LEN 1 // [A-Z] + #ifdef CONFIG_TDX_CFG_BLOCK -static char tdx_serial_str[9]; -static char tdx_board_rev_str[6]; +static char tdx_serial_str[SERIAL_STR_LEN + 1]; +static char tdx_board_rev_str[MODULE_VER_STR_LEN + MODULE_REV_STR_LEN + 1]; #ifdef CONFIG_TDX_CFG_BLOCK_EXTRA -static char tdx_car_serial_str[9]; -static char tdx_car_rev_str[6]; +static char tdx_car_serial_str[SERIAL_STR_LEN + 1]; +static char tdx_car_rev_str[MODULE_VER_STR_LEN + MODULE_REV_STR_LEN + 1]; static char *tdx_carrier_board_name; #endif