diff mbox series

[v2] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output

Message ID 20220525075502.295331-1-marcel@ziswiler.com
State Accepted
Commit a3f2dcf8f44445703a1919a5fa83b4328b244f92
Delegated to: Stefano Babic
Headers show
Series [v2] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output | expand

Commit Message

Marcel Ziswiler May 25, 2022, 7:55 a.m. UTC 
From: Philippe Schenker <philippe.schenker@toradex.com>

systemd prints its messages on the last console= statement that it finds
in the kernel arguments. The current ordering sends the systemd messages
to tty1, by default this is the display.

Ensure that systemd sends its messages to the default UART, reorder the
console= statements accordingly.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

Changes in v2:
- Added Stefano's reviewed-by tag.
- Added my acked-by tag.
- Re-based on top of Stefano's master-next.

 include/configs/verdin-imx8mm.h | 4 ++--
 include/configs/verdin-imx8mp.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Stefano Babic June 15, 2022, 11:11 a.m. UTC | #1 
> From: Philippe Schenker <philippe.schenker@toradex.com>
> systemd prints its messages on the last console= statement that it finds
> in the kernel arguments. The current ordering sends the systemd messages
> to tty1, by default this is the display.
> Ensure that systemd sends its messages to the default UART, reorder the
> console= statements accordingly.
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index cd950ad055e..558b78115df 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -58,8 +58,8 @@ 
 	"fdt_board=dev\0" \
 	"initrd_addr=0x43800000\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"setup=setenv setupargs console=${console},${baudrate} " \
-		"console=tty1 consoleblank=0 earlycon\0" \
+	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
+		"consoleblank=0 earlycon\0" \
 	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
 		"if test \"$confirm\" = \"y\"; then " \
 		"setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt " \
diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
index 470f64d5a74..52fa2be3ab1 100644
--- a/include/configs/verdin-imx8mp.h
+++ b/include/configs/verdin-imx8mp.h
@@ -75,7 +75,7 @@ 
 	"fdt_board=dev\0" \
 	"initrd_addr=0x43800000\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"setup=setenv setupargs console=${console},${baudrate} console=tty1 " \
+	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
 		"consoleblank=0 earlycon\0" \
 	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
 		"if test \"$confirm\" = \"y\"; then " \