diff mbox series

mvebu: uDPU: include fixed-phy support

Message ID 20220506115443.50988-1-robert.marko@sartura.hr
State Awaiting Upstream
Delegated to: Stefan Roese
Headers show
Series mvebu: uDPU: include fixed-phy support | expand

Commit Message

Robert Marko May 6, 2022, 11:54 a.m. UTC
uDPU relies on using fixed-phy for the SFP support, and since the
fixed-phy parsing was moved to the generic driver instead of mvneta
networking stopped working on uDPU with:
uDPU>> dhcp
dm_eth_phy_connect failed

This is due to the conversion commit not enabling fixed-phy support
in defconfig like it did for other boards.

Fixes: 77fcf3cf1251 ("net: mvneta: Convert to use PHY_FIXED for fixed-link")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 configs/uDPU_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese May 6, 2022, 12:21 p.m. UTC | #1
On 06.05.22 13:54, Robert Marko wrote:
> uDPU relies on using fixed-phy for the SFP support, and since the
> fixed-phy parsing was moved to the generic driver instead of mvneta
> networking stopped working on uDPU with:
> uDPU>> dhcp
> dm_eth_phy_connect failed
> 
> This is due to the conversion commit not enabling fixed-phy support
> in defconfig like it did for other boards.
> 
> Fixes: 77fcf3cf1251 ("net: mvneta: Convert to use PHY_FIXED for fixed-link")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/uDPU_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
> index f2852ad29b..f7cd1a0589 100644
> --- a/configs/uDPU_defconfig
> +++ b/configs/uDPU_defconfig
> @@ -70,6 +70,7 @@ CONFIG_SPI_FLASH_STMICRO=y
>   CONFIG_SPI_FLASH_MTD=y
>   CONFIG_PHYLIB_10G=y
>   CONFIG_PHY_MARVELL=y
> +CONFIG_PHY_FIXED=y
>   CONFIG_PHY_GIGE=y
>   CONFIG_E1000=y
>   CONFIG_MVNETA=y

Viele Grüße,
Stefan Roese
Stefan Roese May 17, 2022, 7:54 a.m. UTC | #2
On 06.05.22 13:54, Robert Marko wrote:
> uDPU relies on using fixed-phy for the SFP support, and since the
> fixed-phy parsing was moved to the generic driver instead of mvneta
> networking stopped working on uDPU with:
> uDPU>> dhcp
> dm_eth_phy_connect failed
> 
> This is due to the conversion commit not enabling fixed-phy support
> in defconfig like it did for other boards.
> 
> Fixes: 77fcf3cf1251 ("net: mvneta: Convert to use PHY_FIXED for fixed-link")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   configs/uDPU_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
> index f2852ad29b..f7cd1a0589 100644
> --- a/configs/uDPU_defconfig
> +++ b/configs/uDPU_defconfig
> @@ -70,6 +70,7 @@ CONFIG_SPI_FLASH_STMICRO=y
>   CONFIG_SPI_FLASH_MTD=y
>   CONFIG_PHYLIB_10G=y
>   CONFIG_PHY_MARVELL=y
> +CONFIG_PHY_FIXED=y
>   CONFIG_PHY_GIGE=y
>   CONFIG_E1000=y
>   CONFIG_MVNETA=y

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
index f2852ad29b..f7cd1a0589 100644
--- a/configs/uDPU_defconfig
+++ b/configs/uDPU_defconfig
@@ -70,6 +70,7 @@  CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_MTD=y
 CONFIG_PHYLIB_10G=y
 CONFIG_PHY_MARVELL=y
+CONFIG_PHY_FIXED=y
 CONFIG_PHY_GIGE=y
 CONFIG_E1000=y
 CONFIG_MVNETA=y