| Message ID | 20220506043759.8193-8-n-francis@ti.com |
|---|---|
| State | RFC |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Integration of sysfw, tispl and tiboot3 | expand |
On 06/05/2022 07:37, Neha Malcom Francis wrote: > Intention of patch is to move the signing and packaging of tiboot3.bin > image to binman, thus removing target from makefile. > > Also deleting k3_gen_x509_cert.sh which was earlier used to sign a > binary associated with K3 devices with x509 certificate. This > functionality has been replicated in binman with the etype x509_cert. > > Signed-off-by: Neha Malcom Francis <n-francis@ti.com> > --- > arch/arm/mach-k3/config.mk | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk > index e6c13c1800..49f80ae79b 100644 > --- a/arch/arm/mach-k3/config.mk > +++ b/arch/arm/mach-k3/config.mk > @@ -46,25 +46,6 @@ INPUTS-y += sec-cfg.bin > endif > endif > > -# tiboot3.bin is mandated by ROM and ROM only supports R5 boot. > -# So restrict tiboot3.bin creation for CPU_V7R. > -ifdef CONFIG_CPU_V7R > -image_check: $(obj)/u-boot-spl.bin FORCE > - @if [ $(IMAGE_SIZE) -gt $(MAX_SIZE) ]; then \ > - echo "===============================================" >&2; \ > - echo "ERROR: Final Image too big. " >&2; \ > - echo "$< size = $(IMAGE_SIZE), max size = $(MAX_SIZE)" >&2; \ > - echo "===============================================" >&2; \ > - exit 1; \ > - fi > - > -tiboot3.bin: image_check FORCE > - $(srctree)/tools/k3_gen_x509_cert.sh -c 16 -b $(obj)/u-boot-spl.bin \ > - -o $@ -l $(CONFIG_SPL_TEXT_BASE) -k $(KEY) > - > -INPUTS-y += tiboot3.bin > -endif > - Instead of removing it unconditionally and breaking build for all this must be placed under #ifndef CONFIG_BINMAN ... #endif > ifdef CONFIG_ARM64 > > ifeq ($(CONFIG_SOC_K3_J721E),) cheers, -roger
diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk index e6c13c1800..49f80ae79b 100644 --- a/arch/arm/mach-k3/config.mk +++ b/arch/arm/mach-k3/config.mk @@ -46,25 +46,6 @@ INPUTS-y += sec-cfg.bin endif endif -# tiboot3.bin is mandated by ROM and ROM only supports R5 boot. -# So restrict tiboot3.bin creation for CPU_V7R. -ifdef CONFIG_CPU_V7R -image_check: $(obj)/u-boot-spl.bin FORCE - @if [ $(IMAGE_SIZE) -gt $(MAX_SIZE) ]; then \ - echo "===============================================" >&2; \ - echo "ERROR: Final Image too big. " >&2; \ - echo "$< size = $(IMAGE_SIZE), max size = $(MAX_SIZE)" >&2; \ - echo "===============================================" >&2; \ - exit 1; \ - fi - -tiboot3.bin: image_check FORCE - $(srctree)/tools/k3_gen_x509_cert.sh -c 16 -b $(obj)/u-boot-spl.bin \ - -o $@ -l $(CONFIG_SPL_TEXT_BASE) -k $(KEY) - -INPUTS-y += tiboot3.bin -endif - ifdef CONFIG_ARM64 ifeq ($(CONFIG_SOC_K3_J721E),)
Intention of patch is to move the signing and packaging of tiboot3.bin image to binman, thus removing target from makefile. Also deleting k3_gen_x509_cert.sh which was earlier used to sign a binary associated with K3 devices with x509 certificate. This functionality has been replicated in binman with the etype x509_cert. Signed-off-by: Neha Malcom Francis <n-francis@ti.com> --- arch/arm/mach-k3/config.mk | 19 ------------------- 1 file changed, 19 deletions(-)