| Message ID | 20220505142126.1.I46677af5f2426ff2eef1afa2365059a93019ed87@changeid |
|---|---|
| State | Accepted |
| Commit | 8202c958cfe24f0ffb6f6817fb3dc75ecaf8da12 |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | ARM: stm32: Use CONFIG_TFTP_TSIZE on STMicroelectronics boards | expand |
Hi Patrick On 5/5/22 14:21, Patrick Delaunay wrote: > Long TFTP transfers lead to a wall of # characters on UART, which in > the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to > print progress in fewer # characters. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > configs/stm32mp15_basic_defconfig | 1 + > configs/stm32mp15_defconfig | 1 + > configs/stm32mp15_trusted_defconfig | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig > index 5d1b2e0fd7..1b1c255b98 100644 > --- a/configs/stm32mp15_basic_defconfig > +++ b/configs/stm32mp15_basic_defconfig > @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > # CONFIG_SPL_ENV_IS_NOWHERE is not set > # CONFIG_SPL_ENV_IS_IN_SPI_FLASH is not set > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_SET_DFU_ALT_INFO=y > CONFIG_USB_FUNCTION_FASTBOOT=y > diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig > index f6e7fc81b0..02b37e14ea 100644 > --- a/configs/stm32mp15_defconfig > +++ b/configs/stm32mp15_defconfig > @@ -61,6 +61,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" > CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_CLK_SCMI=y > CONFIG_SET_DFU_ALT_INFO=y > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig > index 855a394893..df31c0fbb1 100644 > --- a/configs/stm32mp15_trusted_defconfig > +++ b/configs/stm32mp15_trusted_defconfig > @@ -62,6 +62,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" > CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_CLK_SCMI=y > CONFIG_SET_DFU_ALT_INFO=y Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
On 5/5/22 14:21, Patrick Delaunay wrote: > Long TFTP transfers lead to a wall of # characters on UART, which in > the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to > print progress in fewer # characters. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > configs/stm32mp15_basic_defconfig | 1 + > configs/stm32mp15_defconfig | 1 + > configs/stm32mp15_trusted_defconfig | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig > index 5d1b2e0fd7..1b1c255b98 100644 > --- a/configs/stm32mp15_basic_defconfig > +++ b/configs/stm32mp15_basic_defconfig > @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > # CONFIG_SPL_ENV_IS_NOWHERE is not set > # CONFIG_SPL_ENV_IS_IN_SPI_FLASH is not set > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_SET_DFU_ALT_INFO=y > CONFIG_USB_FUNCTION_FASTBOOT=y > diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig > index f6e7fc81b0..02b37e14ea 100644 > --- a/configs/stm32mp15_defconfig > +++ b/configs/stm32mp15_defconfig > @@ -61,6 +61,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" > CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_CLK_SCMI=y > CONFIG_SET_DFU_ALT_INFO=y > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig > index 855a394893..df31c0fbb1 100644 > --- a/configs/stm32mp15_trusted_defconfig > +++ b/configs/stm32mp15_trusted_defconfig > @@ -62,6 +62,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" > CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=-1 > +CONFIG_TFTP_TSIZE=y > CONFIG_STM32_ADC=y > CONFIG_CLK_SCMI=y > CONFIG_SET_DFU_ALT_INFO=y Applied to u-boot-stm32 Thanks Patrice
diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig index 5d1b2e0fd7..1b1c255b98 100644 --- a/configs/stm32mp15_basic_defconfig +++ b/configs/stm32mp15_basic_defconfig @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=-1 # CONFIG_SPL_ENV_IS_NOWHERE is not set # CONFIG_SPL_ENV_IS_IN_SPI_FLASH is not set +CONFIG_TFTP_TSIZE=y CONFIG_STM32_ADC=y CONFIG_SET_DFU_ALT_INFO=y CONFIG_USB_FUNCTION_FASTBOOT=y diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig index f6e7fc81b0..02b37e14ea 100644 --- a/configs/stm32mp15_defconfig +++ b/configs/stm32mp15_defconfig @@ -61,6 +61,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=-1 +CONFIG_TFTP_TSIZE=y CONFIG_STM32_ADC=y CONFIG_CLK_SCMI=y CONFIG_SET_DFU_ALT_INFO=y diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig index 855a394893..df31c0fbb1 100644 --- a/configs/stm32mp15_trusted_defconfig +++ b/configs/stm32mp15_trusted_defconfig @@ -62,6 +62,7 @@ CONFIG_ENV_UBI_VOLUME="uboot_config" CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=-1 +CONFIG_TFTP_TSIZE=y CONFIG_STM32_ADC=y CONFIG_CLK_SCMI=y CONFIG_SET_DFU_ALT_INFO=y
Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- configs/stm32mp15_basic_defconfig | 1 + configs/stm32mp15_defconfig | 1 + configs/stm32mp15_trusted_defconfig | 1 + 3 files changed, 3 insertions(+)