From patchwork Tue Apr 19 07:52:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bedel, Alban" X-Patchwork-Id: 1618819 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=l2task.onmicrosoft.com header.i=@l2task.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-l2task-onmicrosoft-com header.b=IRpyi/nR; dkim=fail reason="signature verification failed" (1024-bit key) header.d=l2task.onmicrosoft.com header.i=@l2task.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-l2task-onmicrosoft-com header.b=q3y+yVy8; dkim=pass (2048-bit key; unprotected) header.d=aerq.com header.i=@aerq.com header.a=rsa-sha256 header.s=hse1 header.b=dqJTFhQ3; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KjLZT12s2z9sFx for ; Tue, 19 Apr 2022 21:05:53 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD8E683C1E; Tue, 19 Apr 2022 13:05:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=aerq.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=l2task.onmicrosoft.com header.i=@l2task.onmicrosoft.com header.b="IRpyi/nR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=l2task.onmicrosoft.com header.i=@l2task.onmicrosoft.com header.b="q3y+yVy8"; dkim=pass (2048-bit key; unprotected) header.d=aerq.com header.i=@aerq.com header.b="dqJTFhQ3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B842883868; Tue, 19 Apr 2022 09:53:24 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mx-relay76-hz1.antispameurope.com (mx-relay76-hz1.antispameurope.com [94.100.133.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6851083AFF for ; Tue, 19 Apr 2022 09:53:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=aerq.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alban.bedel@aerq.com Received: from mail-vi1eur04lp2051.outbound.protection.outlook.com ([104.47.14.51]) by mx-relay76-hz1.antispameurope.com; Tue, 19 Apr 2022 09:53:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=l2task.onmicrosoft.com; s=selector1-l2task-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDHNelM50x/GPsmIO98Lbz/NpCUZNmuZAH2jZdIDF3c=; b=IRpyi/nRSdJQG/MImiZkHKnAorkUoqqFbs8GmPOMF35Ih82+Q/7ww1MNOW+6ddZtKo4AGQnoYvloZ/LENHodCxef7S90u2gEJzQq2PwxdpE6NeDoC6TlYbdFmpYTfvTuu6Yld3xI6G4B2kdKS9dUoii/GYg+20hFijsILNHCswE= Received: from AS9PR06CA0321.eurprd06.prod.outlook.com (2603:10a6:20b:45b::23) by GV1PR10MB5939.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:5b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 07:53:10 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::8a) by AS9PR06CA0321.outlook.office365.com (2603:10a6:20b:45b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Tue, 19 Apr 2022 07:53:10 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 104.40.229.156) smtp.mailfrom=aerq.com; dkim=fail (body hash did not verify) header.d=l2task.onmicrosoft.com;dmarc=fail action=quarantine header.from=aerq.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning aerq.com discourages use of 104.40.229.156 as permitted sender) Received: from eu1.smtp.exclaimer.net (104.40.229.156) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 07:53:09 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (104.47.0.57) by eu1.smtp.exclaimer.net (104.40.229.156) with Exclaimer Signature Manager ESMTP Proxy eu1.smtp.exclaimer.net (tlsversion=TLS12, tlscipher=TLS_ECDHE_WITH_AES256_SHA384); Tue, 19 Apr 2022 07:53:09 +0000 X-ExclaimerHostedSignatures-MessageProcessed: true X-ExclaimerProxyLatency: 6374533 X-ExclaimerImprintLatency: 350502 X-ExclaimerImprintAction: 92e6afc066b14ad69a4823e73e1fa549 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX5zkQnbwh2dcdkYzXJguzIxuZDdhHnYz+S+WHFSeD4pgrS6UUqdoxmtivY/ojqO00TxRCjAtesf0ouAml4uIqn5DR8gtOsAm1N/oMgUOjJUVSjlZApu38T9P8lhNl5rDCWW7bY88n0kYPbgSHIAARpg4/ABb5DQyua0fBiilfqoSnoI9vWlxgPFSdekVkXlshluLN7l2XM9YAglg4Or/6HKz7HNP7GGoZSn5Y74q+VduiRO7lut0MB1c3Io05zWX0b7bykO8/xYJwEwnq2zz5ggaNGEZP2FVDIGQ7JPr8E6NLXMyhkcLSbY6yrr3+7X+ma14WPzGHlTgYXNR+VSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=84XuTk5mlbMFfSJQ6BcJHOic3qUPFQGkO30S3ELp/xs=; b=OiLNt0lnzeh32MoVvKoGXTRyShVqtIgtlJ2qroWLXnpKsuiEUV0j6J5mjWGaHRzM2GMN7TrbTaCbL9kCzQhJe/gqzUfyug8dti8YH1VhEAopFIIptj904al7TFIK3Tv90s1FzILaLu1trXei6/tSuFFwYgB+UD1VFU1Bu3a5Gr6Yc7QS2OR2SgkpzIKOqUeOTwTtS1SLMadU9+SPPVS4Lzz0E3oz76KFIuushux8xpelsM093HRmUfvpz+/QdPBDMD2O7BVOUeF3cb4iigm6PbumHHbsz5wOpSWDsNWAVwxH15TAqT7iZUpn4sbBPxC8PutpRML0qLcQrq6XnW+vTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aerq.com; dmarc=pass action=none header.from=aerq.com; dkim=pass header.d=aerq.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=l2task.onmicrosoft.com; s=selector1-l2task-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84XuTk5mlbMFfSJQ6BcJHOic3qUPFQGkO30S3ELp/xs=; b=q3y+yVy8hLIhfLzsLK1yrtXG7mZVl4Pj7OYegpXpSYH7j6LQwPqNXIvGlv9MwUzKPVoAg4FzrZ+04S56JfhMCB5AqQ1DAXyTnRIyeFnBatm1ZQtDBNjtjoU0S294xSFcMeMwe/pmOelEJ8QMMpLU2WL/vsgzc/ahSnfCS7dagEM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aerq.com; Received: from AS8PR10MB5000.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:405::24) by VI1PR1001MB1133.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:70::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 07:52:56 +0000 Received: from AS8PR10MB5000.EURPRD10.PROD.OUTLOOK.COM ([fe80::c88b:46b9:deb7:c8c5]) by AS8PR10MB5000.EURPRD10.PROD.OUTLOOK.COM ([fe80::c88b:46b9:deb7:c8c5%9]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022 07:52:56 +0000 From: Alban Bedel To: u-boot@lists.denx.de CC: Marek Vasut , Michael Walle , Priyanka Jain , Angus Ainslie , Alban Bedel Subject: [PATCH 1/2] usb: dwc3: core: Fix warnings when building without driver model Date: Tue, 19 Apr 2022 09:52:24 +0200 Message-ID: <20220419075225.73161-3-alban.bedel@aerq.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220419075225.73161-1-alban.bedel@aerq.com> References: <20220419075225.73161-1-alban.bedel@aerq.com> X-ClientProxiedBy: AS9PR06CA0125.eurprd06.prod.outlook.com (2603:10a6:20b:467::21) To AS8PR10MB5000.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:405::24) X-MS-Office365-Filtering-Correlation-Id: d09bf749-a003-4196-d1db-08da21d9a5c9 X-MS-TrafficTypeDiagnostic: VI1PR1001MB1133:EE_|AM5EUR03FT007:EE_|GV1PR10MB5939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FANLIh7+eyckJHqzjtawxFGqQ+jzApQ2c3A4ZjXpikDlvz5WVjZAgZeHA+4ECJBSOob8l0qoUCkyeyqjovp0hZQLaR1o2ZOHwQfovZ+Hno/7OcLE+ZwicB5GCAldaC1tlXC2R1nA5SDFF5oazBAUKDrTpO6c7sIUUPsGCslKKwPubfnpgyGg/aCAAqMI7/S0GSEdRGep7KSbnv7myr2e9f9ydWT3gzkDQvgSV22AAtt8t6w3mhSbhIqU63oxwqtVcaVx12YK65JbR3j9Ha65yN5g6eWzIPu3KAugeljMn5+PMSbHQcBcYmNmXWFLL8bZj5rKun5DEBJnm03WAiYI2TKgEGy0SBlaK4mTpX87jSbs3KMP0hR7XQPcz2MANNrEwlNF2WZCawd7OEx7BF10UwXXUrL633qRLErvXw5hkJ3MDegcapTRS1g5KpLxImhgSFj2Cx4OsL/L4Nj9934HVHsyrRbUK7TdnA48YX1JUtjMnTHsUgyvuoJ/mBU1ur1EyD/FTh6WbKgNbm1iP6d2igvRVsKi54q08AEj4yT2l0cPjiJv1TCb9/pKmG2910QffVImMt/QtkwuJ7idaRTqej6gOVIFtmL9kCYtKd3TxaTv4CsF5vCcEj0tYM3HJT/zudQsu7TiCHvA+yONA6kAdw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR10MB5000.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(44832011)(82960400001)(54906003)(508600001)(8676002)(8936002)(4326008)(66946007)(6486002)(5660300002)(66556008)(66476007)(38100700002)(2906002)(6916009)(107886003)(1076003)(36756003)(186003)(316002)(52116002)(86362001)(6506007)(6666004)(83380400001)(2616005)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR1001MB1133 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c0b4d0a-7059-4b4f-a3f1-08da21d99d83 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NiUrZYMWjPjHd/jDVJWUNteULdfW1IdQNKNXW3FRFTC22he0NOUBZfwe/oEKHVWWNJ8WSpox1Gx+d0GwEIpQyzwu8+manCTTTrnzENieEdCyEoR/Uk14asuJytaE4VY2hkHRfIj/RiiVISS+K7PckVHsYAcXewFsGdW0tNxzYEQYMKF4L3oLaha/q8nUeW0h9Wz58/1ziziJyTS6CjLAkUZ6MnpSzl87FaXFrdgz87Rkb4ad5y88BuIuOqy7krdCI3n1S1+jx9dSjs6DrwXsCEG9x8M265+AD8hkYRRd9PFFJR+SW19/6sA1bBllqTikCT1T+2y0M8n6hTFiuGfbkYOV/ipT+Ds7V77WhGJMIbL1+8qsp1bqm69I9TopvIEoy2WgIb4B1UxZawu+NNuWAvZUObhF2gDMD9FhH/UZ32Ejd6/sIM+aaFWor7sfebVU7gmXX5HAwoPa29hmOwqVmj7kqZysrGKVSmKuZ8jk/4OiINaxMgq+A0LQvK8vKoqA28XZqxcHfi/b5m0ss6/Ik0aM/hAZZj/qIEmjuS0/bHHB/hv1UgZ+7pKW8gne1QAjKBh4Auw9hGI3UkZOTeRgyDkrFzEpB7D5SLpn+AOuxuYDUhcjHKyxT202m0g8Jh6qUYjj5L61pllmBWnD59z3zg== X-Forefront-Antispam-Report: CIP:104.40.229.156; CTRY:NL; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:eu1.smtp.exclaimer.net; PTR:eu1.smtp.exclaimer.net; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(70586007)(36756003)(70206006)(82960400001)(107886003)(36860700001)(1076003)(316002)(54906003)(356005)(7636003)(6916009)(7596003)(8676002)(82310400005)(4326008)(47076005)(8936002)(6486002)(5660300002)(2616005)(44832011)(86362001)(508600001)(6506007)(6666004)(186003)(336012)(6512007)(83380400001)(26005)(2906002); DIR:OUT; SFP:1102; X-OriginatorOrg: aerq.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 07:53:09.5056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d09bf749-a003-4196-d1db-08da21d9a5c9 X-MS-Exchange-CrossTenant-Id: bf24ff3e-ad0a-4c79-a44a-df7092489e22 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bf24ff3e-ad0a-4c79-a44a-df7092489e22; Ip=[104.40.229.156]; Helo=[eu1.smtp.exclaimer.net] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB5939 MIME-Version: 1.0 X-cloud-security-sender: alban.bedel@aerq.com X-cloud-security-recipient: u-boot@lists.denx.de X-cloud-security-crypt: load encryption module X-cloud-security-crypt-policy: TRYSMIME X-cloud-security-Mailarchiv: E-Mail archived for: alban.bedel@aerq.com X-cloud-security-Mailarchivtype: outbound X-cloud-security-Virusscan: CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay76-hz1.antispameurope.com with 085281BE1AE3 X-cloud-security-connect: mail-vi1eur04lp2051.outbound.protection.outlook.com[104.47.14.51], TLS=1, IP=104.47.14.51 X-cloud-security-Digest: b4bf6c6955daad83e0a5c91ab61c7623 X-cloud-security-crypt: smime sign status=06 sign_complete X-cloud-security: scantime:1.856 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=aerq.com; h=from:to:cc :subject:date:message-id:in-reply-to:references :content-transfer-encoding:mime-version:content-type; s=hse1; bh=Gi6waaq/9fJaBvH4xDSoxCAXYAh185I5KmRu64lMASs=; b=dqJTFhQ3mojY keSBLJLUwborS94vMNuS6a/a5EzLv0KRRJkrh/ulpkAVqiJORud5t4bh/pWnCI/D 056preeF1QnXtegxwFWIJsB5+IK/2G7N/FPJko7ciD6N+MVH0FNIHbhye6fQemUm oTE8q7ec0RN7AKnE4MC+ajPXHL4WJ3CAP8YAntWOz/DVOEmDJEZq6pVSbIzmVCTG bnA1btY7vRtHlNuvUjKgAGyxt7pk960xfnafyMmNaU3fyHllpwW3wu64zfDc++rl QLc6jrOU9exkebGVmz4IE4VZXPtwu8I6Q5ySAZhLMnrbWB4lH0w5O4+PvdWSr2Qa Vf3lCXotgg== X-Mailman-Approved-At: Tue, 19 Apr 2022 13:04:55 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Commit f150b8d28b4e ("usb: dwc3: Enable undefined length INCR burst type") introduced code that assign the content of dwc->dev to a variable. But in u-boot the type of this field changes if building with driver model enabled or not. As this variable is then only used once just remove it and use the struct field directly. Another issued was also introduced in commit fb146fbc1ae5 ("usb: dwc3: core: stop the core when it's removed") which define a static function which is only used when the driver model is enabled. Add ifdef around this function to suppress the warning when building without driver model. Signed-off-by: Alban Bedel --- drivers/usb/dwc3/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index b592a487e001..fdd8c5db2460 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -465,7 +465,6 @@ static void dwc3_phy_setup(struct dwc3 *dwc) /* set global incr burst type configuration registers */ static void dwc3_set_incr_burst_type(struct dwc3 *dwc) { - struct udevice *dev = dwc->dev; u32 cfg; if (!dwc->incrx_size) @@ -502,7 +501,7 @@ static void dwc3_set_incr_burst_type(struct dwc3 *dwc) case 1: break; default: - dev_err(dev, "Invalid property\n"); + dev_err(dwc->dev, "Invalid property\n"); break; } @@ -706,6 +705,7 @@ static void dwc3_gadget_run(struct dwc3 *dwc) mdelay(100); } +#if CONFIG_IS_ENABLED(DM_USB) static void dwc3_core_stop(struct dwc3 *dwc) { u32 reg; @@ -713,6 +713,7 @@ static void dwc3_core_stop(struct dwc3 *dwc) reg = dwc3_readl(dwc->regs, DWC3_DCTL); dwc3_writel(dwc->regs, DWC3_DCTL, reg & ~(DWC3_DCTL_RUN_STOP)); } +#endif static void dwc3_core_exit_mode(struct dwc3 *dwc) {