| Message ID | 20220414163623.16500-1-fedor.ross@ifm.com |
|---|---|
| State | Accepted |
| Commit | b1d20ae5a648e50fa7fa20981b4ebc6c5c206fa8 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | ARM: imx: Fix parsing of ROM log event IDs on iMX8M | expand |
Hello Peng, can you please check the parameter of event 0x82 internally? The AN12853 doesn't mention a parameter for ID 0x82, but we see something else coming out of the bootrom of iMX8MN. Best regards, Fedor Am Do., 14. Apr. 2022 um 18:37 Uhr schrieb <fedorross@gmail.com>: > > From: Fedor Ross <fedor.ross@ifm.com> > > It seems like the ROM log events for the iMX8M are not fully covered by > AN12853 i.MX ROMs Log Events, Rev. 0, May 2020. On iMX8M the ROM event > ID 0x82 seems to use parameter0 which stops the parsing because the end > of list is detected too early. > > This patch adds ROM event ID 0x82 and skips the next word if ID 0x82 is > parsed. > > > Fixes: a5ee05cf71 ("ARM: imx: Pick correct eMMC boot partition from ROM log") > > Signed-off-by: Fedor Ross <fedor.ross@ifm.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > arch/arm/mach-imx/imx8m/soc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c > index 8171631db1..4df57cb150 100644 > --- a/arch/arm/mach-imx/imx8m/soc.c > +++ b/arch/arm/mach-imx/imx8m/soc.c > @@ -677,6 +677,7 @@ int spl_mmc_emmc_boot_partition(struct mmc *mmc) > /* Log entries with 1 parameter, skip 1 */ > case 0x80: /* Start to perform the device initialization */ > case 0x81: /* The boot device initialization completes */ > + case 0x82: /* Starts to execute boot device driver pre-config */ > case 0x8f: /* The boot device initialization fails */ > case 0x90: /* Start to read data from boot device */ > case 0x91: /* Reading data from boot device completes */ > -- > 2.20.1 >
Hello Peng, just a gentle ping -- did you already had a chance to check the mentioned parameter of event 0x82? Thanks in advance. Best regards, Fedor On Thu, Apr 14, 2022 at 8:00 PM Fedor Ross <fedorross@gmail.com> wrote: > > Hello Peng, > > can you please check the parameter of event 0x82 internally? The AN12853 > doesn't mention a parameter for ID 0x82, but we see something else coming > out of the bootrom of iMX8MN. > > Best regards, > Fedor
Hello Stefano, do you know why this is in the state 'Superseded' ? Thanks in advance. Best regards, Fedor On Fri, May 6, 2022 at 5:17 PM Fedor Ross <fedorross@gmail.com> wrote: > > Hello Peng, > > just a gentle ping -- did you already had a chance to check the mentioned > parameter of event 0x82? > > Thanks in advance. > > Best regards, > Fedor > > On Thu, Apr 14, 2022 at 8:00 PM Fedor Ross <fedorross@gmail.com> wrote: > > > > Hello Peng, > > > > can you please check the parameter of event 0x82 internally? The AN12853 > > doesn't mention a parameter for ID 0x82, but we see something else coming > > out of the bootrom of iMX8MN. > > > > Best regards, > > Fedor
Hi, Marek pointed me this thread. I admitted I overlooked this patch. Will check internally and back. Regards, Peng. On 4/15/2022 2:00 AM, Fedor Ross wrote: > Hello Peng, > > can you please check the parameter of event 0x82 internally? The AN12853 > doesn't mention a parameter for ID 0x82, but we see something else coming > out of the bootrom of iMX8MN. > > Best regards, > Fedor > > Am Do., 14. Apr. 2022 um 18:37 Uhr schrieb <fedorross@gmail.com>: >> >> From: Fedor Ross <fedor.ross@ifm.com> >> >> It seems like the ROM log events for the iMX8M are not fully covered by >> AN12853 i.MX ROMs Log Events, Rev. 0, May 2020. On iMX8M the ROM event >> ID 0x82 seems to use parameter0 which stops the parsing because the end >> of list is detected too early. >> >> This patch adds ROM event ID 0x82 and skips the next word if ID 0x82 is >> parsed. >> >> >> Fixes: a5ee05cf71 ("ARM: imx: Pick correct eMMC boot partition from ROM > log") >> >> Signed-off-by: Fedor Ross <fedor.ross@ifm.com> >> Cc: Fabio Estevam <festevam@gmail.com> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Peng Fan <peng.fan@nxp.com> >> Cc: Stefano Babic <sbabic@denx.de> >> --- >> arch/arm/mach-imx/imx8m/soc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c >> index 8171631db1..4df57cb150 100644 >> --- a/arch/arm/mach-imx/imx8m/soc.c >> +++ b/arch/arm/mach-imx/imx8m/soc.c >> @@ -677,6 +677,7 @@ int spl_mmc_emmc_boot_partition(struct mmc *mmc) >> /* Log entries with 1 parameter, skip 1 */ >> case 0x80: /* Start to perform the device initialization > */ >> case 0x81: /* The boot device initialization completes */ >> + case 0x82: /* Starts to execute boot device driver > pre-config */ >> case 0x8f: /* The boot device initialization fails */ >> case 0x90: /* Start to read data from boot device */ >> case 0x91: /* Reading data from boot device completes */ >> -- >> 2.20.1 >>
On 4/15/2022 12:36 AM, fedorross@gmail.com wrote: > From: Fedor Ross <fedor.ross@ifm.com> > > It seems like the ROM log events for the iMX8M are not fully covered by > AN12853 i.MX ROMs Log Events, Rev. 0, May 2020. On iMX8M the ROM event > ID 0x82 seems to use parameter0 which stops the parsing because the end > of list is detected too early. > > This patch adds ROM event ID 0x82 and skips the next word if ID 0x82 is > parsed. > > Fixes: a5ee05cf71 ("ARM: imx: Pick correct eMMC boot partition from ROM log") > > Signed-off-by: Fedor Ross <fedor.ross@ifm.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm/mach-imx/imx8m/soc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c > index 8171631db1..4df57cb150 100644 > --- a/arch/arm/mach-imx/imx8m/soc.c > +++ b/arch/arm/mach-imx/imx8m/soc.c > @@ -677,6 +677,7 @@ int spl_mmc_emmc_boot_partition(struct mmc *mmc) > /* Log entries with 1 parameter, skip 1 */ > case 0x80: /* Start to perform the device initialization */ > case 0x81: /* The boot device initialization completes */ > + case 0x82: /* Starts to execute boot device driver pre-config */ > case 0x8f: /* The boot device initialization fails */ > case 0x90: /* Start to read data from boot device */ > case 0x91: /* Reading data from boot device completes */
> From: Fedor Ross <fedor.ross@ifm.com> > It seems like the ROM log events for the iMX8M are not fully covered by > AN12853 i.MX ROMs Log Events, Rev. 0, May 2020. On iMX8M the ROM event > ID 0x82 seems to use parameter0 which stops the parsing because the end > of list is detected too early. > This patch adds ROM event ID 0x82 and skips the next word if ID 0x82 is > parsed. > Fixes: a5ee05cf71 ("ARM: imx: Pick correct eMMC boot partition from ROM log") > Signed-off-by: Fedor Ross <fedor.ross@ifm.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Reviewed-by: Peng Fan <peng.fan@nxp.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c index 8171631db1..4df57cb150 100644 --- a/arch/arm/mach-imx/imx8m/soc.c +++ b/arch/arm/mach-imx/imx8m/soc.c @@ -677,6 +677,7 @@ int spl_mmc_emmc_boot_partition(struct mmc *mmc) /* Log entries with 1 parameter, skip 1 */ case 0x80: /* Start to perform the device initialization */ case 0x81: /* The boot device initialization completes */ + case 0x82: /* Starts to execute boot device driver pre-config */ case 0x8f: /* The boot device initialization fails */ case 0x90: /* Start to read data from boot device */ case 0x91: /* Reading data from boot device completes */